Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Updates: Redeploy Sandbox via Docker & Fix retry of Codecov upload #2649

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Nov 17, 2023

Follow-up to #2650

Description

This PR is just updates to our GitHub actions including:

  1. Deploying to demo.dspace.org or sandbox.dspace.org after updates to our DockerHub images. (This used to be done via a webhook on DockerHub. But, moving it to GitHub actions so that we can have better control over when the re-deployment is called.)
  2. Fixing a minor bug in the build.yml where the Codecov.io (code coverage) upload is not automatically retrying on failure. The issue seems to be that an upload failure doesn't throw an error by default, so we have to set fail_ci_if_error: true in the Codecov action to get the retry process to work properly.
  3. Upgrading all action plugins to latest versions

Instructions for Reviewers

  • No review is necessary. If these actions continue to work properly then this is a successful update.

@tdonohue tdonohue added bug code task port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Nov 17, 2023
@tdonohue tdonohue changed the title Upgrade all GitHub Actions & fix retry of Codecov upload GitHub Actions Updates: Deploy via Docker & Fix retry of Codecov upload Nov 21, 2023
@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 21, 2023
@tdonohue
Copy link
Member Author

This will need to be ported to dspace-7_x manually.

@tdonohue tdonohue added the backend: Docker related to DSpace deployment via Docker label Nov 21, 2023
@tdonohue tdonohue changed the title GitHub Actions Updates: Deploy via Docker & Fix retry of Codecov upload GitHub Actions Updates: Redeploy Sandbox via Docker & Fix retry of Codecov upload Nov 21, 2023
@tdonohue tdonohue merged commit 4f340d8 into DSpace:main Nov 21, 2023
14 checks passed
@tdonohue tdonohue deleted the update_gh_actions branch November 21, 2023 19:41
@tdonohue
Copy link
Member Author

Ported to dspace-7_x in #2655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Docker related to DSpace deployment via Docker bug code task
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant