-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cache issue when depositing a submission #2596
Conversation
@atarix83 : I tested this PR today, and I can still reproduce both bugs with this fix in place. So, I'm not sure what this is doing? In my setup, I'm running this PR in the UI in production mode (
I've rebuilt this PR twice in case something was cached. I'm just not able to figure out how to test this. Is it working properly for you when running in Production mode? |
@atarix83 ; I re-tested quickly today and I can no longer reproduce the odd behavior I was seeing before. This appears to work, but I want to do some further testing tomorrow before giving it a +1. Apologies, I have no idea what I must have done wrong before. Either I failed to pull down the PR code properly, or some sort of caching was getting in the way. But basic tests on Chrome today show this appears to be working. I'll triple check things tomorrow just to be sure :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @atarix83!
That works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully created backport PR for |
References
Description
This is a quick fix for the problems mentioned before. It's not resolving the general problem with
reRequestOnStale
mentioned hereInstructions for Reviewers
Check the mentioned bugs are fixed
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.