Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required field errors in the submission disappear when you deposit #2664

Open
artlowel opened this issue Nov 28, 2023 · 1 comment
Open

Required field errors in the submission disappear when you deposit #2664

artlowel opened this issue Nov 28, 2023 · 1 comment
Labels
bug component: submission help wanted Needs a volunteer to claim to move forward high priority

Comments

@artlowel
Copy link
Member

Describe the bug
If you open a new submission and immediately click deposit, you'll get a notification saying "Deposit cannot be completed due to errors in the form. Please fill out all required fields to complete the deposit.". Each required field will be highlighted in red with a message underneath saying it's required

However if you first fill out another field in the describe step (e.g. citation) and then click deposit, you'll still get the notification but the required fields won't get that red highlight and error message. Any fields that were already highlighted will lose that highlight

To Reproduce
Steps to reproduce the behavior:

  1. Start a new submission
  2. Optionally click the title field but don't enter any value. You'll see it get highlighted in red
  3. Fill out the citation field
  4. Click deposit
  5. You'll notice that the required fields aren't highlighted, and if you did step 2, you'll notice its highlight has disappeared

Expected behavior
All required fields should be highlighted in red, so the user knows what to do to successfully complete the submission

@artlowel artlowel added bug component: submission needs triage New issue needs triage and/or scheduling labels Nov 28, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 28, 2023
@tdonohue
Copy link
Member

Based on the description of how to reproduce this, it sounds semi-related to #1924 (newly fixed in 7.6.1 in #2596 by @atarix83 ). Maybe this is a side effect of that fix?

In any case pulling this over to the 7.6.x board and marking as high priority. Needs a volunteer though to investigate for 8.0 and an eventual 7.6.2

@tdonohue tdonohue added high priority and removed needs triage New issue needs triage and/or scheduling labels Nov 28, 2023
@tdonohue tdonohue added the help wanted Needs a volunteer to claim to move forward label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: submission help wanted Needs a volunteer to claim to move forward high priority
Projects
Development

No branches or pull requests

2 participants