Limit edit item modal results #2011

KoenP · 2022-12-22T21:05:20Z

References

Builds on PR#1999
Fixes #1331
Related backend PR

Description

The frontend PR ensures that, when a user clicks Edit->Item in the admin sidebar, they only see items they have permission to edit. The backend PR extends the REST API with a findItemsWithEdit search method to support quickly finding these relevant items.

Instructions for Reviewers

List of changes in this PR:

New component EditableItemSelectorComponent, which renders a list of items that are editable by the current user.
EditItemSelectorComponent now uses a custom template instead of the generic DSOSelectorModalWrapperComponent template.
BaseItemDataService: now implements SearchData<Item> and defines a new method findItemsWithEdit, which calls a new REST method with the same name to retrieve the list of items for which the current user has editing rights.

Manual testing can be done via the REST API at /api/core/items/search/findItemsWithEdit or via the frontend.

Make a user and grant that user editing rights on some items in various ways
- via direct resource policty
- by making the user admin of a collection with some items in it
- by making the user admin of a community with some collections with some items in it...
Either call into the REST API or use the frontend to verify only these items are returned.
Add a query to verify only relevant items are returned.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
My PR passes ESLint validation using yarn lint
My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
If my PR fixes an issue ticket, I've linked them together.

…dit->Item menu (admin sidebar). Currently there are still build issues.

…rameters

github-actions · 2023-01-03T09:06:59Z

Hi @KoenP,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2023-01-03T14:29:36Z

Hi @KoenP,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

tdonohue

@KoenP : I tried to test this today, but I cannot build this PR when I apply it to the latest main. It appears this PR may be accidentally undoing many of the changes to the "shared.module.ts" which were recently applied to main.

We could always wait to rebase this after #1999 is fully merged (I think it's close). But, I just wanted to let you know that this PR appears to have build issues right now.

…item-modal-results

tdonohue

👍 @KoenP : I tested and reviewed this today. I have a few very minor inline requests which I'd like to be resolved prior to merger. However, this works well, so I'll go ahead and approve it.

tdonohue · 2023-01-23T17:57:06Z

src/app/core/shared/operators.ts

@@ -54,6 +54,15 @@ export const getFirstSucceededRemoteWithNotEmptyData = <T>() =>
  (source: Observable<RemoteData<T>>): Observable<RemoteData<T>> =>
    source.pipe(find((rd: RemoteData<T>) => rd.hasSucceeded && isNotEmpty(rd.payload)));

+export const mapRemoteDataPayload = <T,U>(fn: (payload: T) => U) =>


Can we add a comment or TypeDocs to describe how/when to use this? See for example how "getFirstSucceededRemoteDataPayload" is described (and others below it.)

tdonohue · 2023-01-23T18:01:08Z

src/app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component.ts

@@ -14,7 +14,8 @@ import { Item } from '../../../../core/shared/item.model';

 @Component({
  selector: 'ds-edit-item-selector',
-  templateUrl: '../dso-selector-modal-wrapper.component.html',
+  templateUrl: './edit-item-selector.component.html',
+  // templateUrl: '../dso-selector-modal-wrapper.component.html',


Can we remove the commented out code here?

github-actions · 2023-01-24T15:14:29Z

Hi @KoenP,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

artlowel

Thanks @KoenP!

The code in this PR looks good and it works well.

However I noticed some cases where the solr index seemed to be outdated after adding or removing a user from a group. I made a comment about it on the rest PR: DSpace/DSpace#8616 (comment)

Koen Pauwels added 4 commits December 13, 2022 16:46

97257 Started implementing filtering based on editing rights in the E…

aa8e9fd

…dit->Item menu (admin sidebar). Currently there are still build issues.

97257 Filtering "Edit->Item" menu based on permissions

ba78ff6

97257 Reworked ItemDataService.findItemsWithEdit, added pagination pa…

c15481f

…rameters

97257 findItemsWithEdit now no longer ignores query parameter

0625a91

KoenP changed the title ~~W2p 97257 limit edit item modal results~~ Limit edit item modal results Dec 22, 2022

KoenP mentioned this pull request Dec 22, 2022

Limit edit item modal results DSpace/DSpace#8616

Open

8 tasks

97257 Tests for ItemSearchService and EditableItemSelectorComponent

f3a47d5

github-actions bot added the merge conflict label Jan 3, 2023

Koen Pauwels added 2 commits January 3, 2023 11:31

97257 Cleanup

b372777

97257 Processing review feedback

7982259

github-actions bot removed the merge conflict label Jan 3, 2023

KoenP force-pushed the w2p-97257_limit-edit-item-modal-results branch from b68e39f to 7982259 Compare January 3, 2023 14:29

github-actions bot added the merge conflict label Jan 3, 2023

github-actions bot removed the merge conflict label Jan 3, 2023

KoenP marked this pull request as ready for review January 3, 2023 15:44

tdonohue assigned KoenP Jan 5, 2023

tdonohue requested review from tdonohue and artlowel January 5, 2023 15:32

ybnd mentioned this pull request Jan 12, 2023

DSO selector modals show results by relevance even if no query is given #2041

Closed

tdonohue added bug authorization related to authorization, permissions or groups labels Jan 18, 2023

tdonohue requested changes Jan 18, 2023

View reviewed changes

KoenP force-pushed the w2p-97257_limit-edit-item-modal-results branch from 258009c to 14a45fa Compare January 23, 2023 10:00

Merge remote-tracking branch 'dspace/main' into w2p-97257_limit-edit-…

4526097

…item-modal-results

KoenP force-pushed the w2p-97257_limit-edit-item-modal-results branch from 14a45fa to 4526097 Compare January 23, 2023 14:38

tdonohue self-requested a review January 23, 2023 18:03

tdonohue approved these changes Jan 23, 2023

View reviewed changes

github-actions bot added the merge conflict label Jan 24, 2023

tdonohue mentioned this pull request Jan 24, 2023

Fix user authorization issues with admin sidebar DSpace/DSpace#8607

Merged

8 tasks

artlowel approved these changes Jan 26, 2023

View reviewed changes

artlowel changed the base branch from main to ui-demo February 2, 2023 16:41

artlowel changed the base branch from ui-demo to main February 2, 2023 16:41

tdonohue requested review from tdonohue and artlowel February 3, 2023 15:09

tdonohue added this to the 7.6 milestone Feb 3, 2023

tdonohue added the work in progress label Mar 23, 2023

tdonohue removed this from the 7.6 milestone Jun 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Limit edit item modal results #2011

Limit edit item modal results #2011

KoenP commented Dec 22, 2022 •

edited

Loading

github-actions bot commented Jan 3, 2023

github-actions bot commented Jan 3, 2023

tdonohue left a comment

tdonohue left a comment

tdonohue Jan 23, 2023

tdonohue Jan 23, 2023

github-actions bot commented Jan 24, 2023

artlowel left a comment

Limit edit item modal results #2011

Are you sure you want to change the base?

Limit edit item modal results #2011

Conversation

KoenP commented Dec 22, 2022 • edited Loading

References

Description

Instructions for Reviewers

Checklist

github-actions bot commented Jan 3, 2023

github-actions bot commented Jan 3, 2023

tdonohue left a comment

Choose a reason for hiding this comment

tdonohue left a comment

Choose a reason for hiding this comment

tdonohue Jan 23, 2023

Choose a reason for hiding this comment

tdonohue Jan 23, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 24, 2023

artlowel left a comment

Choose a reason for hiding this comment

KoenP commented Dec 22, 2022 •

edited

Loading