97257 Processing review feedback

DSpace · Jan 3, 2023 · 7982259 · 7982259
1 parent b372777
commit 7982259
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 10 deletions.
diff --git a/...ed/dso-selector/dso-selector/editable-item-selector/editable-item-selector.component.html b/...ed/dso-selector/dso-selector/editable-item-selector/editable-item-selector.component.html
diff --git a/...dso-selector/dso-selector/editable-item-selector/editable-item-selector.component.spec.ts b/...dso-selector/dso-selector/editable-item-selector/editable-item-selector.component.spec.ts
@@ -41,18 +41,31 @@ describe('EditableItemSelectorComponent', () => {
     ['1','2','3'].map(createFindItemsResult),
     ['4','5','6'].map(createFindItemsResult),
   ];
-  const itemDataService = {
-    findItemsWithEdit: (query: string, options: FindListOptions,
-                        useCachedVersionIfAvailable = true, reRequestOnStale = true) => {
-      return createSuccessfulRemoteDataObject$(createPaginatedList(
-        query.startsWith('search.resourceid') ? [currentResult] : pages[options.currentPage - 1]
-      ));
-    }
-  };
+
+/*
+    beforeEach(() => {
+    dsoService = {
+      findByIdAndIDType: jasmine.createSpy('findByIdAndIDType').and.returnValue(observableOf({ hasFailed: false,
+        hasSucceeded: true }))
+    };
+    guard = new LookupGuard(dsoService);
+  });
+ */
+  let itemDataService;
   let notificationsService: NotificationsService;
 
   beforeEach(waitForAsync( () => {
     notificationsService = jasmine.createSpyObj('notificationsService', ['error']);
+    itemDataService = {
+      findItemsWithEdit: jasmine.createSpy('findItemsWithEdit').and.callFake(
+        (query: string, options: FindListOptions,
+         useCachedVersionIfAvailable = true, reRequestOnStale = true) => {
+          return createSuccessfulRemoteDataObject$(createPaginatedList(
+            query.startsWith('search.resourceid') ? [currentResult] : pages[options.currentPage - 1]
+          ));
+        }
+      )
+    };
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot()],
       declarations: [EditableItemSelectorComponent],
@@ -109,7 +122,7 @@ describe('EditableItemSelectorComponent', () => {
 
     describe('when search returns an error', () => {
       beforeEach(() => {
-        spyOn(itemDataService, 'findItemsWithEdit').and.returnValue(createFailedRemoteDataObject$());
+        itemDataService.findItemsWithEdit.and.returnValue(createFailedRemoteDataObject$());
         component.ngOnInit();
       });