Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context): Handle cycles in move_edges #108

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(context): Handle cycles in move_edges #108

merged 1 commit into from
Jun 18, 2024

Conversation

ewuerger
Copy link
Member

Common UUID was detected as the target and source itself. This commit fixes it by just removing this UUID from both sets.

@ewuerger
fix(context): Handle cycles in move_edges
b553713 
Common UUID was detected as the target and source itself. This commit fixes it by just removing this UUID from both sets.
@ewuerger ewuerger requested a review from vik378 as a code owner June 18, 2024 04:35
@ewuerger ewuerger self-assigned this Jun 18, 2024
@ewuerger ewuerger requested a review from huyenngn June 18, 2024 04:35
@ewuerger ewuerger mentioned this pull request Jun 18, 2024
Merged
huyenngn
huyenngn approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@huyenngn huyenngn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 03d8285 into main Jun 18, 2024
10 checks passed
@ewuerger ewuerger deleted the fix-portless branch June 18, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenngn huyenngn huyenngn approved these changes

@vik378 vik378 Awaiting requested review from vik378 vik378 is a code owner

Assignees

@ewuerger ewuerger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @huyenngn