Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing ROS2 messages into Capella model #3

Merged
merged 47 commits into from
May 30, 2024
Merged

Importing ROS2 messages into Capella model #3

merged 47 commits into from
May 30, 2024

Conversation

huyenngn
Copy link
Member

No description provided.

@huyenngn huyenngn requested a review from vik378 January 10, 2024 12:37
CONTRIBUTING.md Outdated Show resolved Hide resolved
@huyenngn huyenngn requested review from ewuerger and removed request for vik378 January 10, 2024 13:08
pyproject.toml Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/modules/messages/parser.py Outdated Show resolved Hide resolved
capella_ros_tools/modules/capella/serializer.py Outdated Show resolved Hide resolved
capella_ros_tools/modules/capella/serializer.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/msg2capella.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/capella2msg.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/capella2msg.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/msg2capella.py Outdated Show resolved Hide resolved
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite some things to do. If you also want to do some more refactoring to standardize the methods on the converters, we can hop into a pair-programming session.

capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/__init__.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/capella2msg.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/capella2msg.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/capella2msg.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/msg2capella.py Outdated Show resolved Hide resolved
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with filenames coming from class names including a / in the export is also apparent in the import. This needs to be handled both ways.

When this is done: LGTM.

.github/workflows/build-test-publish.yml Outdated Show resolved Hide resolved
capella_ros_tools/scripts/export_capella.py Outdated Show resolved Hide resolved
capella_ros_tools/messages.py Outdated Show resolved Hide resolved
capella_ros_tools/messages.py Outdated Show resolved Hide resolved
capella_ros_tools/capella.py Outdated Show resolved Hide resolved
capella_ros_tools/viewer/app.py Outdated Show resolved Hide resolved
capella_ros_tools/viewer/app.py Outdated Show resolved Hide resolved
capella_ros_tools/viewer/templates/class.html Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look for the type annotations also in the test modules.
After my requested changes: LGTM.

tests/test_messages.py Outdated Show resolved Hide resolved
tests/test_messages.py Outdated Show resolved Hide resolved
tests/test_messages.py Outdated Show resolved Hide resolved
tests/test_messages.py Outdated Show resolved Hide resolved
tests/test_messages.py Outdated Show resolved Hide resolved
tests/test_capella.py Outdated Show resolved Hide resolved
tests/test_capella.py Outdated Show resolved Hide resolved
tests/test_capella.py Outdated Show resolved Hide resolved
tests/test_capella.py Outdated Show resolved Hide resolved
@huyenngn huyenngn requested a review from ewuerger March 6, 2024 14:37
@huyenngn huyenngn force-pushed the msg2cap branch 3 times, most recently from 0ec3d8e to f6e3152 Compare March 6, 2024 16:28
Copy link

github-actions bot commented Mar 6, 2024

The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/.
We also strongly recommend that you set up your development environment with pre-commit, as described in our CONTRIBUTING guidelines. This will run all the important checks right before you commit your changes, and avoids lengthy CI wait time and round trips.

This is the commit validation log:

⧗   input: fix:Eliminate duplicates
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: chore: update toml file
✖   subject must be sentence-case [subject-case]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: fix: overwrite overlap
✖   subject must be sentence-case [subject-case]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Here are some examples of valid commit messages:

build: Bump dependency versions
docs(user): Add model creation workflow
feat: Add a monitoring dashboard

capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/__init__.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/import_msgs.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/import_msgs.py Outdated Show resolved Hide resolved
capella_ros_tools/data_model.py Outdated Show resolved Hide resolved
capella_ros_tools/data_model.py Outdated Show resolved Hide resolved
capella_ros_tools/scripts/import_msgs.py Outdated Show resolved Hide resolved
capella_ros_tools/__main__.py Outdated Show resolved Hide resolved
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Mar 6, 2024
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Mar 6, 2024
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Mar 6, 2024
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Mar 6, 2024
@DSD-DBS DSD-DBS deleted a comment from github-actions bot Mar 6, 2024
@Wuestengecko
Copy link
Member

And also, please fix the commit messages. The bot is slowly approaching the point where funny turns into annoying. :)

@huyenngn huyenngn force-pushed the msg2cap branch 2 times, most recently from fb25fb3 to 120d1c8 Compare March 18, 2024 10:17
@huyenngn huyenngn requested a review from Wuestengecko March 20, 2024 09:56
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good! I like how far we are here. After my tiny requested changes: LGTM.

README.md Outdated Show resolved Hide resolved
capella_ros_tools/data_model.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@huyenngn huyenngn merged commit b01cc46 into master May 30, 2024
7 checks passed
@huyenngn huyenngn deleted the msg2cap branch May 30, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants