feat: Add possibilities to archive t4c instances #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominik003
changed the title
dominik003
force-pushed
the
feat-archive-t4c-server
branch
3 times, most recently
from
bf51bbc to
91a4b2a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 71.06% 71.15% +0.08%
==========================================
Files 155 156 +1
Lines 4869 4891 +22
Branches 522 524 +2
==========================================
+ Hits 3460 3480 +20
- Misses 1312 1313 +1
- Partials 97 98 +1
☔ View full report in Codecov by Sentry. |
dominik003
force-pushed
the
feat-archive-t4c-server
branch
from
91a4b2a to
9579da7
Compare
Paula-Kli
reviewed
Sep 26, 2023
Paula-Kli
previously requested changes
Sep 26, 2023
...rc/app/settings/modelsources/t4c-settings/edit-t4c-instance/edit-t4c-instance.component.html
Outdated
Show resolved
Hide resolved
.../src/app/settings/modelsources/t4c-settings/edit-t4c-instance/edit-t4c-instance.component.ts
Outdated
Show resolved
Hide resolved
|
Use |
dominik003
force-pushed
the
feat-archive-t4c-server
branch
2 times, most recently
from
3922000 to
28f1647
Compare
MoritzWeber0
approved these changes
Oct 2, 2023
backend/capellacollab/alembic/versions/f7bf9456cfc9_add_archive_flag.py
Outdated
Show resolved
Hide resolved
...rc/app/settings/modelsources/t4c-settings/edit-t4c-instance/edit-t4c-instance.component.html
Outdated
Show resolved
Hide resolved
Paula-Kli
force-pushed
the
feat-archive-t4c-server
branch
from
28f1647 to
d282337
Compare
dominik003
force-pushed
the
feat-archive-t4c-server
branch
2 times, most recently
from
428c1f9 to
5d25ebb
Compare
MoritzWeber0
requested changes
Oct 9, 2023
dominik003
force-pushed
the
feat-archive-t4c-server
branch
3 times, most recently
from
eb6c2f0 to
b73f50c
Compare
dominik003
force-pushed
the
feat-archive-t4c-server
branch
from
b73f50c to
fbda95b
Compare
This sets the port when running mkdocs to 8081, so as not to interfere with a running backend on 8080.
dominik003
force-pushed
the
feat-archive-t4c-server
branch
from
fbda95b to
4c4bfe2
Compare
MoritzWeber0
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an archive flag to the t4c instances. When set the t4c instances should be grayed out in the drop down menu (i.e., no longer be selectable) and one should no longer be able to edit the instance. However, existing linked models should still work as expected.
Resolves #970