Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minimize styling changes affected by Angular upgrade #1317

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: Minimize styling changes affected by Angular upgrade #1317

merged 1 commit into from
Feb 6, 2024

Conversation

romeonicholas
Copy link
Contributor

@romeonicholas romeonicholas commented Feb 5, 2024 •
edited
Loading

Lingering issues copied from #1195:

  • Unused scrollable class deleted
  • Duplicated "Models" header in model overview deleted
  • User text and icons in project user settings vertically centered
  • White background on Monitoring cards text removed
  • Move Model and Reorder Models modal headers enlarged
  • Diagram cache preview header enlarged
  • Diagram cache preview scrollbars removed (waiting for rate-limiting to reset, can't actually load anything 😆 )
  • Project configuration and model name headers removed from respective forms
  • Text sizes in administrative user settings fixed
  • Gaps between T4C instance settings cards added in
  • Persistent workspace button back stretched to full width (also stretched the select inputs above it at mobile width)
  • Global font styling that broke configurations editor removed

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d881415) 73.21% compared to head (562b5cb) 73.21%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1317   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         166      166           
  Lines        5428     5428           
  Branches      607      607           
=======================================
  Hits         3974     3974           
  Misses       1323     1323           
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeonicholas romeonicholas force-pushed the fix-angular-update-styling branch from 386f33a to c9beda1 Compare February 5, 2024 18:54
@romeonicholas romeonicholas force-pushed the fix-angular-update-styling branch from c9beda1 to 562b5cb Compare February 5, 2024 19:02
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@romeonicholas romeonicholas marked this pull request as ready for review February 5, 2024 19:07
MoritzWeber0
MoritzWeber0 requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the great improvements and addressing all of the issues mentioned. Especially, I love the little changes you make along the way to improve the code :)

I found another few issues, please have a look at them. I'll merge this one again, you can address those in a follow-up PR.

...s-wrapper/create-sessions/create-persistent-session/create-persistent-session.component.html Show resolved Hide resolved
frontend/src/app/settings/core/user-settings/user-settings.component.html Show resolved Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html Show resolved Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html Show resolved Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html Show resolved Hide resolved
frontend/src/styles.css Show resolved Hide resolved
frontend/src/styles.css Show resolved Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
@@ -32,7 +32,7 @@ <h2>View diagrams</h2>
</span>
<div class="flex flex-wrap">
<div
class="collab-card !flex grow basis-[calc(30%-20px)] flex-col justify-between"
class="collab-card !flex grow basis-[calc(30%-20px)] flex-col justify-between gap-5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The skeleton loader is not centered horizontally (there is small difference between the left and right margins)

@MoritzWeber0 MoritzWeber0 merged commit 7164bee into main Feb 6, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-angular-update-styling branch February 6, 2024 10:08
@romeonicholas romeonicholas mentioned this pull request Feb 8, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romeonicholas @MoritzWeber0