Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update styling to minimize changes from Angular upgrade #1333

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

romeonicholas
Copy link
Contributor

@romeonicholas romeonicholas commented Feb 8, 2024

Copied from #1317

Requested changes:

  • Persistent workspace button centered
  • User settings component avatar clipping fixed (also vertically centered the right side buttons that were out of alignment)
  • Model diagram gap moved out from inside individual cards to between model cards
  • Model diagram download button centered
  • Model diagram skeleton loader centered
  • capellambse code snippet copy button centered
  • Model creation git base integration URL input widened, and space added below Resulting URL section
  • Remove scrollbars from persistent workspace connect modal (this is hard to test without the full setup on my non-work computer but it's caused buttons with ripple elements at the botom of dialogs so I think I've got it)

Other stuff:

  • Put icons on the right side in a few places where it was still on the left
    • Open internal session viewer, open session viewer

http://localhost:4200/settings/modelsources/git
image
@MoritzWeber0 The above issue wasn't a problem for me locally at any width so I didn't make any changes (see below), but let me know if you continue to see it.
Screenshot 2024-02-08 at 17 13 25

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ae1847) 73.22% compared to head (0b99fd3) 73.34%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   73.22%   73.34%   +0.11%     
==========================================
  Files         166      166              
  Lines        5431     5462      +31     
  Branches      608      616       +8     
==========================================
+ Hits         3977     4006      +29     
- Misses       1323     1325       +2     
  Partials      131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0
Copy link
Member

The above issue wasn't a problem for me locally at any width so I didn't make any changes (see below), but let me know if you continue to see it.

Looks fine indeed, can't reproduce it anymore.

@romeonicholas
Copy link
Contributor Author

romeonicholas commented Feb 8, 2024

The skeleton loader has proven hard to deal with between API rate limiting and the animation tools in Chrome seemingly not working properly on it, not sure if there's a better way to work with it.

Edit: never mind, I figured it out, the theme used in the code doesn't show up as a class in the DOM so even though it said it was at full width the theme was subtracting 10 pixels for some reason, removed that bit

@romeonicholas romeonicholas force-pushed the angular-style-update branch 2 times, most recently from 90e203b to 8375630 Compare February 9, 2024 08:37
@romeonicholas romeonicholas marked this pull request as ready for review February 9, 2024 08:40
@MoritzWeber0
Copy link
Member

The skeleton loader has proven hard to deal with between API rate limiting and the animation tools in Chrome seemingly not working properly on it, not sure if there's a better way to work with it.

One good way is to mock the server response, e.g., with Insomnia

Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit b4a9c9c into main Feb 9, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the angular-style-update branch February 9, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants