-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update styling to minimize changes from Angular upgrade #1333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
+ Coverage 73.22% 73.34% +0.11%
==========================================
Files 166 166
Lines 5431 5462 +31
Branches 608 616 +8
==========================================
+ Hits 3977 4006 +29
- Misses 1323 1325 +2
Partials 131 131 ☔ View full report in Codecov by Sentry. |
...s-wrapper/create-sessions/create-persistent-session/create-persistent-session.component.html
Outdated
Show resolved
Hide resolved
Looks fine indeed, can't reproduce it anymore. |
398d95c
to
fa5565d
Compare
The skeleton loader has proven hard to deal with between API rate limiting and the animation tools in Chrome seemingly not working properly on it, not sure if there's a better way to work with it. Edit: never mind, I figured it out, the theme used in the code doesn't show up as a class in the DOM so even though it said it was at full width the theme was subtracting 10 pixels for some reason, removed that bit |
90e203b
to
8375630
Compare
One good way is to mock the server response, e.g., with Insomnia |
...ons/user-sessions-wrapper/active-sessions/connection-dialog/connection-dialog.component.html
Outdated
Show resolved
Hide resolved
...agrams/model-diagram-dialog/model-diagram-code-block/model-diagram-code-block.component.html
Show resolved
Hide resolved
8375630
to
18882a0
Compare
18882a0
to
0b99fd3
Compare
Quality Gate passedIssues Measures |
Copied from #1317
Requested changes:
Other stuff:
http://localhost:4200/settings/modelsources/git
@MoritzWeber0 The above issue wasn't a problem for me locally at any width so I didn't make any changes (see below), but let me know if you continue to see it.