Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use commitlint to enfore conventional commits #1290

Closed
wants to merge 2 commits into from

Conversation

MoritzWeber0
Copy link
Member

commitlint has a better CLI, which allows to enforce conventional commits in a GitHub Actions pipeline.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fecea1) 72.83% compared to head (dd34b9e) 72.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1290   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         162      162           
  Lines        5345     5345           
  Branches      601      601           
=======================================
  Hits         3893     3893           
  Misses       1321     1321           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DSD-DBS DSD-DBS deleted a comment from github-actions bot Jan 25, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the commitlint branch 3 times, most recently from 97bf723 to 7f4cef8 Compare January 25, 2024 07:32
`commitlint` has a better CLI, which allows to enforce
conventional commits in a GitHub Actions pipeline.
Copy link

The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/.
We also strongly recommend that you set up your development environment with pre-commit, as described in our Developer documentation. This will run all the important checks right before you commit your changes, and avoids lengthy CI wait time and round trips.

This is the commit validation log:

⧗   input: test invalid commit
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Here are some examples of valid commit messages:

build: Bump frontend versions
docs(user): Add model creation workflow
feat: Add a monitoring dashboard

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant