Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use commitlint to enfore conventional commits #1291

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Jan 25, 2024

commitlint has a better CLI, which allows to enforce conventional commits in a GitHub Actions pipeline.

If you want to see an example comment, check this (closed) PR: #1290

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fecea1) 72.83% compared to head (8abe331) 72.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1291   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         162      162           
  Lines        5345     5345           
  Branches      601      601           
=======================================
  Hits         3893     3893           
  Misses       1321     1321           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

`commitlint` has a better CLI, which allows to enforce
conventional commits in a GitHub Actions pipeline.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I can no longer cheat by rebasing commits 😆 .

@MoritzWeber0 MoritzWeber0 merged commit 02ce4dc into main Jan 26, 2024
25 checks passed
@MoritzWeber0 MoritzWeber0 deleted the commitlint branch January 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants