-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix documentation according to user feedback #1206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
=======================================
Coverage 72.83% 72.83%
=======================================
Files 162 162
Lines 5345 5345
Branches 601 601
=======================================
Hits 3893 3893
Misses 1321 1321
Partials 131 131 ☔ View full report in Codecov by Sentry. |
4c494dd
to
1027f72
Compare
1027f72
to
bee5898
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@amolenaar Can you review the changes from the "user" perspective? Are the workflows still correct? |
e10eb1a
to
69b1ff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs. I have just a few comments and after they are resolved we can merge this one.
69b1ff4
to
aba0d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks more clear this way.
One small improvement suggestion.
aba0d3e
to
89d70a4
Compare
The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/. This is the commit validation log:
Here are some examples of valid commit messages:
|
83c7d96
to
8358647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement, looks good in general :)
There is a new Github action to check for mkdocs warnings, please rebase on main to get it in this PR.
In addition, I have two small comments. Once they are resolved, the PR can be merged.
Conversations are resolved & @dominik003 is out of office.
Remove video for jupyter notebook introduction. Move settings documentation from user to administrator documentation. Some smaller adjustments.
8358647
to
ebc17d8
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
In the jupyter section was a video that I was not able to open locally neither did it play in the docs - is that just me or a general problem?
Also please read the update of the capella model carefully - not sure whether everything is correct in there