Remove duplication

The cleanup which was done for the error is the same as the default cleanup, so error out later after the normal cleanup.
DOMjudge · Oct 1, 2023 · 4e951e9 · 4e951e9
1 parent 1b358ee
commit 4e951e9
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -1504,16 +1504,6 @@ protected function importSubmission(string $entityType, ?string $eventId, string
                 $this->addOrUpdateWarning($eventId, $entityType, $data['id'], ExternalSourceWarning::TYPE_SUBMISSION_ERROR, [
                     'message' => 'Cannot add submission: ' . $message,
                 ]);
-                // Clean up the temporary submission files.
-                foreach ($filesToSubmit as $file) {
-                    unlink($file->getRealPath());
-                }
-                if (isset($zip)) {
-                    $zip->close();
-                }
-                if ($shouldUnlink) {
-                    unlink($zipFile);
-                }
                 return;
             }