Swap around to show why next commit makes sense.

DOMjudge · Oct 1, 2023 · 1b358ee · 1b358ee
1 parent 193695d
commit 1b358ee
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -1488,6 +1488,18 @@ protected function importSubmission(string $entityType, ?string $eventId, string
                 message: $message,
                 forceImportInvalid: !$submissionDownloadSucceeded
             );
+            // Clean up the ZIP.
+            if (isset($zip)) {
+                $zip->close();
+            }
+            if ($shouldUnlink) {
+                unlink($zipFile);
+            }
+
+            // Clean up the temporary submission files.
+            foreach ($filesToSubmit as $file) {
+                unlink($file->getRealPath());
+            }
             if (!$submission) {
                 $this->addOrUpdateWarning($eventId, $entityType, $data['id'], ExternalSourceWarning::TYPE_SUBMISSION_ERROR, [
                     'message' => 'Cannot add submission: ' . $message,
@@ -1505,18 +1517,6 @@ protected function importSubmission(string $entityType, ?string $eventId, string
                 return;
             }
 
-            // Clean up the ZIP.
-            if (isset($zip)) {
-                $zip->close();
-            }
-            if ($shouldUnlink) {
-                unlink($zipFile);
-            }
-
-            // Clean up the temporary submission files.
-            foreach ($filesToSubmit as $file) {
-                unlink($file->getRealPath());
-            }
         }
 
         if ($submissionDownloadSucceeded) {