Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection information #9

Merged
merged 1 commit into from
May 30, 2024
Merged

Connection information #9

merged 1 commit into from
May 30, 2024

Conversation

jelu
Copy link
Member

@jelu jelu commented May 29, 2024

  • Add conn_info object, UDP/TCP/TLS/QUIC connection information including resumption and latency

@jelu
Copy link
Member Author

jelu commented May 29, 2024

@pspacek @nicki-krizek This is my suggestion on how to add connection information into a stats object.

It uses the same way as the other objects that it's based on "type": "..." which means there can only be one.

They also inherit each other, so TCP has all the props from UDP, TLS from TCP etc etc.

"type": "object",
"properties": {
"packets_sent": {
"description": "The number of packets sent",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packets or datagrams? it becoms important when fragmentation is at play ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I donno, suggestion? It also needs to work when inherit into TCP/TLS... etc

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, it should not be shared. There is no information about number of packets for TCP as normally we don't have any visibility into SYN/ACK/retry magic around TCP.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread migrated to separate issue: #10

"description": "An object with the metrics around the TCP connections used to sent and received for the given stats object",
"properties": {
"handshakes": {
"description": "The number of handshakes performed",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performed = successful? or attempted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 this is cut&paste from @nicki-krizek 's comment

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread migrated to: #11

Comment on lines +215 to +249
"conn_latency_stats": {
"type": "object",
"properties": {
"avg": {
"description": "The average latency, in nanoseconds",
"type": "integer"
},
"min": {
"description": "The minimum latency, in nanoseconds",
"type": "integer"
},
"max": {
"description": "The maximum latency, in nanoseconds",
"type": "integer"
},
"stddev": {
"description": "The standard deviation for latency, in nanoseconds",
"type": "integer"
},
"buckets": {
"description": "??TODO??",
"type": "array",
"items": {
"type": "array",
"items": {
"type": "integer"
}
}
}
}
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can have a generic "latency" object in the schema and reference it from all other places? It should be the same for DNS queries as well, I think.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread migrated to: #12

@pspacek
Copy link

pspacek commented May 29, 2024

Thank you! In general it makes sense. I have to run away now but I will have a look at the rendered docs afterwards - probably tomorrow.

@jelu jelu requested a review from a team May 30, 2024 07:54
- Add `conn_info` object, UDP/TCP/TLS/QUIC connection information including resumption and latency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants