Connection information #9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,9 +175,160 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "conn_info": { | ||
| "$ref": "#/$defs/conn_info" | ||
| } | ||
| }, | ||
| "required": [ "since", "until" ] | ||
| }, | ||
| "udp_conn": { | ||
| "title": "DNS Metric UDP Connection Information", | ||
| "description": "An object with the metrics around the UDP connections used to sent and received for the given stats object", | ||
| "type": "object", | ||
| "properties": { | ||
| "packets_sent": { | ||
| "description": "The number of packets sent", | ||
| "type": "integer" | ||
| }, | ||
| "packets_received": { | ||
| "description": "The number of packets received", | ||
| "type": "integer" | ||
| }, | ||
| "socket_errors": { | ||
| "description": "The number of various socket errors that occurred", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| "tcp_conn": { | ||
| "$ref": "#/$defs/udp_conn", | ||
| "title": "DNS Metric TCP Connection Information", | ||
| "description": "An object with the metrics around the TCP connections used to sent and received for the given stats object", | ||
| "properties": { | ||
| "handshakes": { | ||
| "description": "The number of handshakes performed", | ||
|
There was a problem hiding this comment. 🤷 this is cut&paste from @nicki-krizek 's comment |
||
| "type": "integer" | ||
| }, | ||
| "handshakes_failed": { | ||
| "description": "The number of failed handshakes", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| "conn_latency_stats": { | ||
| "type": "object", | ||
| "properties": { | ||
| "avg": { | ||
| "description": "The average latency, in nanoseconds", | ||
| "type": "integer" | ||
| }, | ||
| "min": { | ||
| "description": "The minimum latency, in nanoseconds", | ||
| "type": "integer" | ||
| }, | ||
| "max": { | ||
| "description": "The maximum latency, in nanoseconds", | ||
| "type": "integer" | ||
| }, | ||
| "stddev": { | ||
| "description": "The standard deviation for latency, in nanoseconds", | ||
| "type": "integer" | ||
| }, | ||
| "buckets": { | ||
| "description": "??TODO??", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "integer" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
|
Comment on lines
+219
to
+249
There was a problem hiding this comment. Maybe we can have a generic "latency" object in the schema and reference it from all other places? It should be the same for DNS queries as well, I think. |
||
| "conn_latency": { | ||
| "title": "DNS Metric Connection Latency", | ||
| "description": "An object with the metrics around connection latency used for the given connection information object", | ||
| "type": "object", | ||
| "properties": { | ||
| "initial": { | ||
| "description": "Latency within the handshake, from the initial packet sent to the first reaction received", | ||
| "$ref": "#/$defs/conn_latency_stats" | ||
| }, | ||
| "handshake": { | ||
| "description": "Latency from the initial packet to the handshake completion", | ||
| "$ref": "#/$defs/conn_latency_stats" | ||
| }, | ||
| "connection": { | ||
| "description": "Latency from the initial packet sent to the connection closed, timed outed, failed or abandoned", | ||
| "$ref": "#/$defs/conn_latency_stats" | ||
| } | ||
| } | ||
| }, | ||
| "conn_resumption": { | ||
| "title": "DNS Metric Connection Resumption", | ||
| "description": "An object with the metrics around connection resumption used for the given connection information object", | ||
| "type": "object", | ||
| "properties": { | ||
| "initialized": { | ||
| "description": "The number of attempted resumptions", | ||
| "type": "integer" | ||
| }, | ||
| "established": { | ||
| "description": "The number of resumptions handshakes completed", | ||
| "type": "integer" | ||
| }, | ||
| "fallbacks": { | ||
| "description": "The number of resumptions denied by counterpart", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| "tls_conn": { | ||
| "$ref": "#/$defs/tcp_conn", | ||
| "title": "DNS Metric TLS Connection Information", | ||
| "description": "An object with the metrics around the TLS connections used to sent and received for the given stats object", | ||
| "properties": { | ||
| "resumption": { | ||
| "$ref": "#/$defs/conn_resumption" | ||
| } | ||
| } | ||
| }, | ||
| "quic_conn": { | ||
| "$ref": "#/$defs/tls_conn", | ||
| "title": "DNS Metric QUIC Connection Information", | ||
| "description": "An object with the metrics around the QUIC connections used to sent and received for the given stats object", | ||
| "properties": { | ||
| } | ||
| }, | ||
| "conn_info": { | ||
| "oneOf": [ | ||
| { | ||
| "properties": { | ||
| "type": { "const": "udp" } | ||
| }, | ||
| "$ref": "#/$defs/udp_conn" | ||
| }, | ||
| { | ||
| "properties": { | ||
| "type": { "const": "tcp" } | ||
| }, | ||
| "$ref": "#/$defs/tcp_conn" | ||
| }, | ||
| { | ||
| "properties": { | ||
| "type": { "const": "tls_conn" } | ||
| }, | ||
| "$ref": "#/$defs/tls_conn" | ||
| }, | ||
| { | ||
| "properties": { | ||
| "type": { "const": "quic_conn" } | ||
| }, | ||
| "$ref": "#/$defs/quic_conn" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,5 +29,10 @@ | |
| 1 | ||
| ] | ||
| ] | ||
| }, | ||
| "conn_info": { | ||
| "type": "udp", | ||
| "packets_sent": 100, | ||
| "packets_received": 100 | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packets or datagrams? it becoms important when fragmentation is at play ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I donno, suggestion? It also needs to work when inherit into TCP/TLS... etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, it should not be shared. There is no information about number of packets for TCP as normally we don't have any visibility into SYN/ACK/retry magic around TCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thread migrated to separate issue: #10