-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-2465 resume lesson modal #2352
base: develop
Are you sure you want to change the base?
Changes from 10 commits
931d72c
7b70dce
757c417
2a0091d
7ca5933
c631a10
66a9264
8649ed9
d16ac6d
7268346
582f5f9
2de0a4f
04ed3d3
46ac16a
0b1dda9
7f367ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsRepository.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
import LocalizationServices | ||
|
||
class GetResumeLessonProgressModalInterfaceStringsRepository: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface { | ||
|
||
private let localizationServices: LocalizationServices | ||
|
||
init(localizationServices: LocalizationServices) { | ||
self.localizationServices = localizationServices | ||
} | ||
|
||
func getStringsPublisher(translateInLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> { | ||
|
||
let localeId: String = translateInLanguage.localeId | ||
|
||
let interfaceStrings = ResumeLessonProgressModalInterfaceStringsDomainModel( | ||
title: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.title"), | ||
subtitle: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.subtitle"), | ||
startOverButtonText: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.startOverButton"), | ||
continueButtonText: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.continueButton") | ||
) | ||
|
||
return Just(interfaceStrings) | ||
.eraseToAnyPublisher() | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// | ||
// ResumeLessonProgressModalInterfaceStringsDomainModel.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
struct ResumeLessonProgressModalInterfaceStringsDomainModel { | ||
let title: String | ||
let subtitle: String | ||
let startOverButtonText: String | ||
let continueButtonText: String | ||
|
||
static func emptyStrings() -> ResumeLessonProgressModalInterfaceStringsDomainModel { | ||
return ResumeLessonProgressModalInterfaceStringsDomainModel(title: "", subtitle: "", startOverButtonText: "", continueButtonText: "") | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsRepositoryInterface.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
protocol GetResumeLessonProgressModalInterfaceStringsRepositoryInterface { | ||
|
||
func getStringsPublisher(translateInLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsUseCase.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
class GetResumeLessonProgressModalInterfaceStringsUseCase { | ||
|
||
private let getResumeLessonModalInterfaceStringsRepo: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface | ||
|
||
init(getResumeLessonModalInterfaceStringsRepo: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface) { | ||
self.getResumeLessonModalInterfaceStringsRepo = getResumeLessonModalInterfaceStringsRepo | ||
} | ||
|
||
func getStringsPublisher(appLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> { | ||
|
||
return getResumeLessonModalInterfaceStringsRepo | ||
.getStringsPublisher(translateInLanguage: appLanguage) | ||
.eraseToAnyPublisher() | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
// | ||
// ResumeLessonProgressModal.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 10/29/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import SwiftUI | ||
|
||
struct ResumeLessonProgressModal: View { | ||
|
||
private let buttonHeight: CGFloat = 48 | ||
private let modalInset: CGFloat = 28 | ||
private let buttonInset: CGFloat = 20 | ||
private let buttonSpace: CGFloat = 12 | ||
|
||
@ObservedObject private var viewModel: ResumeLessonProgressModalViewModel | ||
|
||
init(viewModel: ResumeLessonProgressModalViewModel) { | ||
self.viewModel = viewModel | ||
} | ||
|
||
var body: some View { | ||
GeometryReader { geometry in | ||
let totalSpaceAroundModal = modalInset * 2 | ||
let modalWidth = geometry.size.width - totalSpaceAroundModal | ||
let totalSpaceAroundButtons = (buttonInset * 2) + buttonSpace | ||
let buttonWidth = (modalWidth - totalSpaceAroundButtons) / 2 | ||
|
||
ZStack { | ||
if #available(iOS 15.0, *) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also @levieggertcru, do you think we can bump the minimum deployment target to 15? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With iOS 18 out I feel like we could. Let me check the analytics data and see where user count is at. Would like to confirm with godtools team as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We got the go ahead to bump to iOS 15 so feel free to make that change in this PR. |
||
Color.clear | ||
.edgesIgnoringSafeArea(.all) | ||
.background(.ultraThinMaterial) | ||
} else { | ||
VisualEffectView(effect: UIBlurEffect(style: .systemUltraThinMaterial)) | ||
.edgesIgnoringSafeArea(.all) | ||
} | ||
|
||
VStack(spacing: 0) { | ||
Text(viewModel.interfaceStringsDomainModel.title) | ||
.font(FontLibrary.sfProTextRegular.font(size: 28)) | ||
.foregroundColor(ColorPalette.gtGrey.color) | ||
.padding(.top, 30) | ||
.padding(.bottom, 15) | ||
|
||
Text(viewModel.interfaceStringsDomainModel.subtitle) | ||
.font(FontLibrary.sfProTextRegular.font(size: 16)) | ||
.foregroundColor(ColorPalette.gtGrey.color) | ||
.multilineTextAlignment(.center) | ||
.padding(.horizontal, buttonInset + 20) | ||
.padding(.bottom, 35) | ||
|
||
HStack(spacing: buttonSpace) { | ||
GTWhiteButton(title: viewModel.interfaceStringsDomainModel.startOverButtonText, width: buttonWidth, height: buttonHeight) { | ||
levieggertcru marked this conversation as resolved.
Show resolved
Hide resolved
|
||
viewModel.startOverButtonTapped() | ||
} | ||
GTBlueButton(title: viewModel.interfaceStringsDomainModel.continueButtonText, width: buttonWidth, height: buttonHeight) { | ||
viewModel.continueButtonTapped() | ||
} | ||
} | ||
.padding(.horizontal, buttonInset) | ||
.padding(.bottom, 21) | ||
} | ||
.background(Color.white) | ||
.cornerRadius(6) | ||
.shadow(color: Color.black.opacity(0.25), radius: 3, y: 3) | ||
.frame(width: modalWidth) | ||
.overlay( | ||
RoundedRectangle(cornerRadius: 6) | ||
.strokeBorder(Color.clear, lineWidth: 2) | ||
) | ||
} | ||
} | ||
|
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// | ||
// ResumeLessonProgressModalViewModel.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
class ResumeLessonProgressModalViewModel: ObservableObject { | ||
|
||
private let getInterfaceStringsUseCase: GetResumeLessonProgressModalInterfaceStringsUseCase | ||
private let getCurrentAppLanguageUseCase: GetCurrentAppLanguageUseCase | ||
private let startOverClosure: () -> Void | ||
private let continueClosure: () -> Void | ||
|
||
private var cancellables: Set<AnyCancellable> = Set() | ||
|
||
@Published private var appLanguage: AppLanguageDomainModel = LanguageCodeDomainModel.english.rawValue | ||
|
||
@Published var interfaceStringsDomainModel: ResumeLessonProgressModalInterfaceStringsDomainModel = ResumeLessonProgressModalInterfaceStringsDomainModel.emptyStrings() | ||
|
||
init(getInterfaceStringsUseCase: GetResumeLessonProgressModalInterfaceStringsUseCase, getCurrentAppLanguageUseCase: GetCurrentAppLanguageUseCase, startOverClosure: @escaping () -> Void, continueClosure: @escaping () -> Void) { | ||
self.getInterfaceStringsUseCase = getInterfaceStringsUseCase | ||
self.getCurrentAppLanguageUseCase = getCurrentAppLanguageUseCase | ||
self.startOverClosure = startOverClosure | ||
self.continueClosure = continueClosure | ||
|
||
getCurrentAppLanguageUseCase | ||
.getLanguagePublisher() | ||
.receive(on: DispatchQueue.main) | ||
.assign(to: &$appLanguage) | ||
|
||
$appLanguage | ||
.dropFirst() | ||
.map { appLanguage in | ||
getInterfaceStringsUseCase.getStringsPublisher(appLanguage: appLanguage) | ||
} | ||
.switchToLatest() | ||
.receive(on: DispatchQueue.main) | ||
.sink { [weak self] interfaceStrings in | ||
|
||
self?.interfaceStringsDomainModel = interfaceStrings | ||
} | ||
.store(in: &cancellables) | ||
} | ||
|
||
// MARK: - Inputs | ||
|
||
func startOverButtonTapped() { | ||
startOverClosure() | ||
} | ||
|
||
func continueButtonTapped() { | ||
continueClosure() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @levieggertcru, how do you feel about the naming convention making some names super long? Was debating to take out the word "progress", but still gonna be pretty long either way 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rachaelblue I know some names get super long. I know we suffix a lot of key names such as UseCase, DomainModel, RepositoryInterface, etc.
And some names get descriptive based on feature so there isn't collisions with other features. (If we could namespace that would help here).
I think we could start omitting Repository from the interface naming.
Maybe
GetResumeLessonInterfaceStringsInterface
or evenGetResumeLessonStringsInterface
. A tiny bit shorter.