-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT-2465 resume lesson modal #2352
Open
rachaelblue
wants to merge
16
commits into
develop
Choose a base branch
from
GT-2465-Resume-Lesson-Modal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
931d72c
show resume lesson modal
rachaelblue 7b70dce
present resume lesson modal from lessonViewModel instead
rachaelblue 757c417
add blurred background view
rachaelblue 2a0091d
adjust modal spacing
rachaelblue 7ca5933
add use case and view model to get interface strings
rachaelblue c631a10
center subtitle
rachaelblue 66a9264
Merge branch 'develop' of https://github.com/CruGlobal/godtools-swift…
rachaelblue 8649ed9
remove unused initialPageConfig param
rachaelblue d16ac6d
remove unused bool
rachaelblue 7268346
clean up
rachaelblue 582f5f9
Merge branch 'develop' of https://github.com/CruGlobal/godtools-swift…
rachaelblue 2de0a4f
present modal from flow and remove closures
rachaelblue 04ed3d3
change font size
rachaelblue 46ac16a
present lesson view after appears
rachaelblue 0b1dda9
actually commit changes
rachaelblue 7f367ba
bump min version to iOS15
rachaelblue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
...rogress/Data-DomainInterface/GetResumeLessonProgressModalInterfaceStringsRepository.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsRepository.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
import LocalizationServices | ||
|
||
class GetResumeLessonProgressModalInterfaceStringsRepository: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface { | ||
|
||
private let localizationServices: LocalizationServices | ||
|
||
init(localizationServices: LocalizationServices) { | ||
self.localizationServices = localizationServices | ||
} | ||
|
||
func getStringsPublisher(translateInLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> { | ||
|
||
let localeId: String = translateInLanguage.localeId | ||
|
||
let interfaceStrings = ResumeLessonProgressModalInterfaceStringsDomainModel( | ||
title: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.title"), | ||
subtitle: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.subtitle"), | ||
startOverButtonText: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.startOverButton"), | ||
continueButtonText: localizationServices.stringForLocaleElseEnglish(localeIdentifier: localeId, key: "lessons.resumeLessonModal.continueButton") | ||
) | ||
|
||
return Just(interfaceStrings) | ||
.eraseToAnyPublisher() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...LessonProgress/Domain/Entities/ResumeLessonProgressModalInterfaceStringsDomainModel.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// | ||
// ResumeLessonProgressModalInterfaceStringsDomainModel.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
struct ResumeLessonProgressModalInterfaceStringsDomainModel { | ||
let title: String | ||
let subtitle: String | ||
let startOverButtonText: String | ||
let continueButtonText: String | ||
|
||
static func emptyStrings() -> ResumeLessonProgressModalInterfaceStringsDomainModel { | ||
return ResumeLessonProgressModalInterfaceStringsDomainModel(title: "", subtitle: "", startOverButtonText: "", continueButtonText: "") | ||
} | ||
} |
15 changes: 15 additions & 0 deletions
15
...ss/Domain/Interface/GetResumeLessonProgressModalInterfaceStringsRepositoryInterface.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsRepositoryInterface.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
protocol GetResumeLessonProgressModalInterfaceStringsRepositoryInterface { | ||
|
||
func getStringsPublisher(translateInLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> | ||
} |
27 changes: 27 additions & 0 deletions
27
...rLessonProgress/Domain/UseCases/GetResumeLessonProgressModalInterfaceStringsUseCase.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// | ||
// GetResumeLessonProgressModalInterfaceStringsUseCase.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
class GetResumeLessonProgressModalInterfaceStringsUseCase { | ||
|
||
private let getResumeLessonModalInterfaceStringsRepo: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface | ||
|
||
init(getResumeLessonModalInterfaceStringsRepo: GetResumeLessonProgressModalInterfaceStringsRepositoryInterface) { | ||
self.getResumeLessonModalInterfaceStringsRepo = getResumeLessonModalInterfaceStringsRepo | ||
} | ||
|
||
func getStringsPublisher(appLanguage: AppLanguageDomainModel) -> AnyPublisher<ResumeLessonProgressModalInterfaceStringsDomainModel, Never> { | ||
|
||
return getResumeLessonModalInterfaceStringsRepo | ||
.getStringsPublisher(translateInLanguage: appLanguage) | ||
.eraseToAnyPublisher() | ||
} | ||
|
||
} |
73 changes: 73 additions & 0 deletions
73
...UserLessonProgress/Presentation/ResumeLessonProgressModal/ResumeLessonProgressModal.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// | ||
// ResumeLessonProgressModal.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 10/29/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import SwiftUI | ||
|
||
struct ResumeLessonProgressModal: View { | ||
|
||
private let buttonHeight: CGFloat = 48 | ||
private let modalInset: CGFloat = 28 | ||
private let buttonInset: CGFloat = 20 | ||
private let buttonSpace: CGFloat = 12 | ||
|
||
@ObservedObject private var viewModel: ResumeLessonProgressModalViewModel | ||
|
||
init(viewModel: ResumeLessonProgressModalViewModel) { | ||
self.viewModel = viewModel | ||
} | ||
|
||
var body: some View { | ||
GeometryReader { geometry in | ||
let totalSpaceAroundModal = modalInset * 2 | ||
let modalWidth = geometry.size.width - totalSpaceAroundModal | ||
let totalSpaceAroundButtons = (buttonInset * 2) + buttonSpace | ||
let buttonWidth = (modalWidth - totalSpaceAroundButtons) / 2 | ||
|
||
ZStack { | ||
Color.clear | ||
.edgesIgnoringSafeArea(.all) | ||
.background(.ultraThinMaterial) | ||
|
||
VStack(spacing: 0) { | ||
Text(viewModel.interfaceStringsDomainModel.title) | ||
.font(FontLibrary.sfProTextRegular.font(size: 28)) | ||
.foregroundColor(ColorPalette.gtGrey.color) | ||
.padding(.top, 30) | ||
.padding(.bottom, 15) | ||
|
||
Text(viewModel.interfaceStringsDomainModel.subtitle) | ||
.font(FontLibrary.sfProTextRegular.font(size: 16)) | ||
.foregroundColor(ColorPalette.gtGrey.color) | ||
.multilineTextAlignment(.center) | ||
.padding(.horizontal, buttonInset + 20) | ||
.padding(.bottom, 35) | ||
|
||
HStack(spacing: buttonSpace) { | ||
GTWhiteButton(title: viewModel.interfaceStringsDomainModel.startOverButtonText, fontSize: 15, width: buttonWidth, height: buttonHeight) { | ||
viewModel.startOverButtonTapped() | ||
} | ||
GTBlueButton(title: viewModel.interfaceStringsDomainModel.continueButtonText, fontSize: 15, width: buttonWidth, height: buttonHeight) { | ||
viewModel.continueButtonTapped() | ||
} | ||
} | ||
.padding(.horizontal, buttonInset) | ||
.padding(.bottom, 21) | ||
} | ||
.background(Color.white) | ||
.cornerRadius(6) | ||
.shadow(color: Color.black.opacity(0.25), radius: 3, y: 3) | ||
.frame(width: modalWidth) | ||
.overlay( | ||
RoundedRectangle(cornerRadius: 6) | ||
.strokeBorder(Color.clear, lineWidth: 2) | ||
) | ||
} | ||
} | ||
|
||
} | ||
} |
57 changes: 57 additions & 0 deletions
57
...nProgress/Presentation/ResumeLessonProgressModal/ResumeLessonProgressModalViewModel.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// | ||
// ResumeLessonProgressModalViewModel.swift | ||
// godtools | ||
// | ||
// Created by Rachael Skeath on 11/14/24. | ||
// Copyright © 2024 Cru. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
import Combine | ||
|
||
class ResumeLessonProgressModalViewModel: ObservableObject { | ||
|
||
private weak var flowDelegate: FlowDelegate? | ||
private let getInterfaceStringsUseCase: GetResumeLessonProgressModalInterfaceStringsUseCase | ||
private let getCurrentAppLanguageUseCase: GetCurrentAppLanguageUseCase | ||
|
||
private var cancellables: Set<AnyCancellable> = Set() | ||
|
||
@Published private var appLanguage: AppLanguageDomainModel = LanguageCodeDomainModel.english.rawValue | ||
|
||
@Published var interfaceStringsDomainModel: ResumeLessonProgressModalInterfaceStringsDomainModel = ResumeLessonProgressModalInterfaceStringsDomainModel.emptyStrings() | ||
|
||
init(flowDelegate: FlowDelegate, getInterfaceStringsUseCase: GetResumeLessonProgressModalInterfaceStringsUseCase, getCurrentAppLanguageUseCase: GetCurrentAppLanguageUseCase) { | ||
self.flowDelegate = flowDelegate | ||
self.getInterfaceStringsUseCase = getInterfaceStringsUseCase | ||
self.getCurrentAppLanguageUseCase = getCurrentAppLanguageUseCase | ||
|
||
getCurrentAppLanguageUseCase | ||
.getLanguagePublisher() | ||
.receive(on: DispatchQueue.main) | ||
.assign(to: &$appLanguage) | ||
|
||
$appLanguage | ||
.dropFirst() | ||
.map { appLanguage in | ||
getInterfaceStringsUseCase.getStringsPublisher(appLanguage: appLanguage) | ||
} | ||
.switchToLatest() | ||
.receive(on: DispatchQueue.main) | ||
.sink { [weak self] interfaceStrings in | ||
|
||
self?.interfaceStringsDomainModel = interfaceStrings | ||
} | ||
.store(in: &cancellables) | ||
} | ||
|
||
// MARK: - Inputs | ||
|
||
func startOverButtonTapped() { | ||
flowDelegate?.navigate(step: .startOverTappedFromResumeLessonModal) | ||
} | ||
|
||
func continueButtonTapped() { | ||
flowDelegate?.navigate(step: .continueTappedFromResumeLessonModal) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @levieggertcru, how do you feel about the naming convention making some names super long? Was debating to take out the word "progress", but still gonna be pretty long either way 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rachaelblue I know some names get super long. I know we suffix a lot of key names such as UseCase, DomainModel, RepositoryInterface, etc.
And some names get descriptive based on feature so there isn't collisions with other features. (If we could namespace that would help here).
I think we could start omitting Repository from the interface naming.
Maybe
GetResumeLessonInterfaceStringsInterface
or evenGetResumeLessonStringsInterface
. A tiny bit shorter.