Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Daily Blockchain Reference Test Workflow Failures #1588

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix: Daily Blockchain Reference Test Workflow Failures #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e1c9e6
Fix workflow failures
DavePearce Nov 28, 2024
2e6e43f
Fixes for GeneralStateTests
DavePearce Nov 28, 2024
0ce8f15
Attempting to resolve gradle issue
DavePearce Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/gradle-ethereum-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ jobs:
reference-tests/build/reports/tests/**/*
tmp/local/*

- name: Failure Notification
if: ${{ failure() || cancelled() }}
uses: slackapi/[email protected]
with:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: webhook-trigger
payload: |
name: "Daily Reference Tests (Rust Corset)"
status: "${{ job.status }}"

ethereum-tests-go-corset:
runs-on: ubuntu-latest-128
Expand All @@ -73,7 +82,7 @@ jobs:
run: cd ./linea-constraints; make zkevm_for_reference_tests.bin -B; cd ..

- name: Generate General State Reference Tests
run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.parallel=true -Dorg.gradle.caching=true
run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.caching=true
env:
JAVA_OPTS: -Dorg.gradle.daemon=false
CORSET_FLAGS: fields,expand,expand,expand
Expand Down Expand Up @@ -101,5 +110,5 @@ jobs:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: webhook-trigger
payload: |
name: "Daily Reference Tests"
name: "Daily Reference Tests (Go Corset)"
status: "${{ job.status }}"
1 change: 0 additions & 1 deletion .github/workflows/reference-blockchain-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ jobs:
- name: Run reference blockchain tests
run: ./gradlew referenceBlockchainTests -x spotlessCheck
timeout-minutes: 180
continue-on-error: true
env:
REFERENCE_TESTS_PARALLELISM: 7
JAVA_OPTS: -Dorg.gradle.daemon=false
Expand Down
3 changes: 2 additions & 1 deletion gradle/lint.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ spotless {
}
groovyGradle {
target '*.gradle'
greclipse('4.21').configFile(rootProject.file('gradle/formatter.properties'))
// Temporarily disabled as was reporting XZFormatException
// greclipse('4.21').configFile(rootProject.file('gradle/formatter.properties'))
endWithNewline()
}
// Below this line are currently only license header tasks
Expand Down
Loading