fix: Daily Blockchain Reference Test Workflow Failures #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, workflow failures are being recorded as passing. The reason for this is simply a flag within the yaml file that was presumably copied over from the original gradle tests. This should now resolve the issus, and make sure that when the workflow fails --- we see that.
DavePearce
force-pushed
the
1577-fix-daily-blockchain-reference-tests
branch
from
97b786c
to
6bb1e8a
Compare
This puts through two minor fixes for the GeneralStateTests. Firstly, it adds notifications from the Rust corset side. Secondly, it drops parallelism from the go-corset side.
DavePearce
force-pushed
the
1577-fix-daily-blockchain-reference-tests
branch
2 times, most recently
from
03730a7
to
9fd3c1d
Compare
There appears to be an issue with running `gradle spotlessCheck` on the CI server.
DavePearce
force-pushed
the
1577-fix-daily-blockchain-reference-tests
branch
from
9fd3c1d
to
0ce8f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, workflow failures are being recorded as passing. The reason for this is simply a flag within the yaml file that was presumably copied over from the original gradle tests. This should now resolve the issus, and make sure that when the workflow fails --- we see that.