Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Fix grammar in thank-you #676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix grammar in thank-you #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CodeHub.iOS/ViewControllers/Application/SupportViewController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public override void ViewDidLoad()
var sendEmail = new BigButtonElement("Email Support", Octicon.Mail);
var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened);

HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!";
HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";
HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who’ve provided feedback!";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Rexogamer. Your suggestion sounds good too, but my goal with this PR is to just fix the who/whom grammar issue. Your change is slightly larger in scope, so I'd prefer to leave it to a separate change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is big enough to be its own PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Rexogamer. I am new to this project, so can you please clarify for me. What is your affiliation with this project? Are you offering your opinion in an official capacity, rejecting my current PR?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean that I don’t think my suggestion is big enough for its own PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for clarifying. To me, that's the beauty of open source. If you feel it's worthwhile to spend your time on a PR for it, then it is big enough for a PR. :)

HeaderView.Image = UIImage.FromBundle("AppIcons60x60");

NavigationItem.BackBarButtonItem = new UIBarButtonItem { Title = "" };
Expand Down