This repository has been archived by the owner on Jul 2, 2022. It is now read-only.
Fix grammar in thank-you #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexogamer
suggested changes
Jun 13, 2020
| @@ -31,7 +31,7 @@ public override void ViewDidLoad() | |||
| var sendEmail = new BigButtonElement("Email Support", Octicon.Mail); | |||
| var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened); | |||
|
|
|||
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!"; | |||
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!"; | |||
There was a problem hiding this comment.
How about:
Suggested change
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!"; | |
| HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who’ve provided feedback!"; |
There was a problem hiding this comment.
Hi, Rexogamer. Your suggestion sounds good too, but my goal with this PR is to just fix the who/whom grammar issue. Your change is slightly larger in scope, so I'd prefer to leave it to a separate change.
There was a problem hiding this comment.
I don’t think this is big enough to be its own PR.
There was a problem hiding this comment.
Hi, Rexogamer. I am new to this project, so can you please clarify for me. What is your affiliation with this project? Are you offering your opinion in an official capacity, rejecting my current PR?
There was a problem hiding this comment.
No, I mean that I don’t think my suggestion is big enough for its own PR.
There was a problem hiding this comment.
Oh, thanks for clarifying. To me, that's the beauty of open source. If you feel it's worthwhile to spend your time on a PR for it, then it is big enough for a PR. :)
|
I agree
…On Saturday, June 13, 2020, Philip M. White ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs
<#676 (comment)>:
> @@ -31,7 +31,7 @@ public override void ViewDidLoad()
var sendEmail = new BigButtonElement("Email Support", Octicon.Mail);
var openIssues = new BigButtonElement("Existing Issues", Octicon.IssueOpened);
- HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all whom provide feedback!";
+ HeaderView.SubText = "This app is the product of hard work and great suggestions! Thank you to all who provide feedback!";
Hi, Rexogamer. I am new to this project, so can you please clarify for me.
What is your affiliation with this project? Are you offering your opinion
in an official capacity, rejecting my current PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A>
.
|
|
Thank you
…On Saturday, June 13, 2020, cadkins052 ***@***.***> wrote:
I agree
On Saturday, June 13, 2020, Philip M. White ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In CodeHub.iOS/ViewControllers/Application/SupportViewController.cs
> <#676 (comment)>:
>
> > @@ -31,7 +31,7 @@ public override void ViewDidLoad()
> var sendEmail = new BigButtonElement("Email Support", Octicon.Mail);
> var openIssues = new BigButtonElement("Existing Issues",
Octicon.IssueOpened);
>
> - HeaderView.SubText = "This app is the product of hard work and great
suggestions! Thank you to all whom provide feedback!";
> + HeaderView.SubText = "This app is the product of hard work and great
suggestions! Thank you to all who provide feedback!";
>
> Hi, Rexogamer. I am new to this project, so can you please clarify for
me.
> What is your affiliation with this project? Are you offering your opinion
> in an official capacity, rejecting my current PR?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#676 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/
AMD4GWTNHM22S63FOTVV2T3RWQBRTANCNFSM4N4ZLU3A>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#676 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMD4GWT4AJNEWZYBRTEOECDRWQ5PNANCNFSM4N4ZLU3A>
.
|
ghost
reviewed
Jul 31, 2020
ghost
approved these changes
Jul 31, 2020
Kalischaa
approved these changes
Sep 16, 2020
lontim701129
approved these changes
Oct 10, 2020
ros2-ship
approved these changes
May 22, 2021
ros2-ship
approved these changes
Aug 30, 2021
ros2-ship
approved these changes
Aug 30, 2021
|
取消订阅
…------------------ 原始邮件 ------------------
发件人: "CodeHubApp/CodeHub" ***@***.***>;
发送时间: 2021年8月30日(星期一) 中午1:37
***@***.***>;
***@***.***>;
主题: Re: [CodeHubApp/CodeHub] Fix grammar in thank-you (#676)
@ros2-ship approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.