-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New project layout, Carthage, SPM [WIP] #179
Conversation
Please assist me in getting this merged into THEN I can make a separate PR from develop to master to discuss all blockers and anything that might be broken. Thank you! |
@orta May I please have a clean working slate for this work? Merging this #179 into develop gives me the extra problem that f539662 is currently breaking. Could this instead be merged into a new branch. Or better, can the To clarify the problem:
Therefore this feature is not compatible with the new project layout. Or, more likely I am not understanding things. |
Also, just because I have nowhere better to discuss this, could the |
Sure, what commit ref do you want the branch off? |
Please branch off master and then this PR is ready to be immediately merged into that new branch. |
Develop is based off master, should be 👍 |
Right now there are a couple extra commits in develop that are incompatible with this branch. Please advise |
I'm not really sure what the commits or the merge conflicts are, I assume these are PRs that came in while this was WIP? If they seem useful take the code, if they don't drop them, given this is mostly a re-write it's fine to rethink |
* upstream/develop: working travis-ci example Move the work for setting up the code coverage into a separate file Add post_install scripts to support gathering code coverage data. Enable gathering coverage data on example project. It may seem like this changes more lines than it needs to, but this is everything that Xcode 7.1.1 changed when I checked the coverage box, and it appears that none of it can be left out for the box to stay checked. Use past participle “run” instead of past tense “ran”.
OK, I just did a |
Awesome! |
awesome |
Thank you! Discussion continued at #183 |
This is an ambitious PR that changes the project layout and closes most open issues. Please help by playing with the proposed code and contributing code fixes or test cases of things that are broken.
How can I play with this PR?
cd
into the directorygem install bundler
bundle install
rake
cd ~/Desktop
pod lib create --verbose --template-url='file:///PATH/TO/pod-template' NewPod
pod
to run this templatePR Status
Wording:
pod-template progress:
baseline template progress: (new feature)
swift template progress:
objective-c template progress: [HELP REQUESTED]
other blockers:
PLEASE HELP REVIEW AND ADD BLOCKERS HERE