Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project layout, Pod 1.0+Carthage+SPM [WIP] #168

Closed
wants to merge 29 commits into from

Conversation

fulldecent
Copy link
Collaborator

@fulldecent fulldecent commented May 6, 2016

Wording:

  • pod-template -- this project
  • template -- a model that can have things changed
  • vendored -- a chosen template with variable substitutions and other updates applied and ready for making an iOS framework

pod-template progress:

  • Make vendoring work
  • Set up testing with rake/rspec to validate the vendoring process (fixes Create a full test #79)
  • Set up Travis CI
  • Update variable substitution process, remove unused code

baseline template progress: (new feature)

swift template progress:

  • Create a hello world example (this is a change), it actually does something
  • Remove FDChessboardView and my name from project, use variable substitution
  • Remove XCode warnings (fixes Recommended project settings #131)

objective-c template progress: [HELP REQUESTED]

  • Translate the current Swift template into Objective-C

other blockers:

PLEASE HELP REVIEW AND ADD BLOCKERS HERE

  • Confirm each set of options works [HELP REQUESTED]

@fulldecent fulldecent changed the title New project layout, Pod 1.0+Carthage+SPM New project layout, Pod 1.0+Carthage+SPM [WIP] May 6, 2016
@orta
Copy link
Member

orta commented May 7, 2016

So, this removes a bunch of features that are not optional, like all the questions, swift / objc support, library choices, optional example applications all of which are blockers on this PR.

Other notes,

  • I don't want the current README for their library changing.
  • I also think at first we shouldn't ship a package.swift file, there's no point in shipping one that won't work by default simply because AFNetworking does - it'll totally throw off anyone trying to know if something supports SPM or not when there's thousands of libraries that have an SPM package but it's not set up or configured right

It's got a while to go, but I'm excited to see progress 👍

@fulldecent
Copy link
Collaborator Author

I fixed the README and removed explicit SPM support.

Also added some VERY BASIC travis CI and testing for this repo. I've never used rspec (or ruby) before but this should be good minimally viable and others can improve :-). There is one error related to CocoaPods but I think we can still commit with that error.

@fulldecent
Copy link
Collaborator Author

Update issue and added work list. Requesting review and help from anyone interested.

@fulldecent
Copy link
Collaborator Author

Right now everything should be working except for the objective-c template.

Please anyone assist with testing this and commenting on anything that it broken.

@orta
Copy link
Member

orta commented May 10, 2016

This definitely has a way to go yet, tests crash on my computer, and even the perfect example ends up un-usable. I want to do some work on the CocoaPods-App 1.0 for the next few days, then I can come and give this polish to make it shippable as a PR to you 👍

There's some nice ideas in here though 👍

screen shot 2016-05-10 at 2 56 01 pm

@fulldecent
Copy link
Collaborator Author

@orta Thanks for your help!

@fulldecent
Copy link
Collaborator Author

fulldecent commented May 12, 2016

This is what I am using to successfully execute the tests:

git clone [email protected]:fulldecent/pod-template.git
cd pod-template/
bundle install --jobs=3 --retry=3
bundle exec rake

@segiddins
Copy link
Member

Looks like the .travis.yml needs to specify a ruby version in it

@fulldecent
Copy link
Collaborator Author

Testing is killing me -- time for bed :-(

@fulldecent
Copy link
Collaborator Author

Now testing is somewhat working

@fulldecent
Copy link
Collaborator Author

To all: please advise and help. What needs to be done here and how can we do it?

# Note: if you ignore the Pods directory, make sure to uncomment
# `pod install` in .travis.yml
#
# Pods/

Gemfile.lock
play
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this come from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates use Rake (installed by Gemfile) for testing in Travis CI.

@orta
Copy link
Member

orta commented Jun 25, 2016

Given that this PRs into master, it cannot be merged until it's 100% production ready - as everyone instantly starts using it, there is no deploy process. So it'll need to have the exact same feature set from before.

You're welcome to PR to a develop branch ( I've just pushed master to it right now ) and then I can help out on some of these, but it's still got some work to do 👍

@fulldecent
Copy link
Collaborator Author

@orta Thank you for ALL your help. I am closing this PR and have opened another one against the Develop branch per your note.

#179

@fulldecent fulldecent closed this Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update project layout for Swift Package Manager Create a full test Recommended project settings
3 participants