Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Port all Backbone code to standard Django templates #1129

Open
2 of 3 tasks
brylie opened this issue Oct 12, 2021 · 12 comments
Open
2 of 3 tasks

[Epic] Port all Backbone code to standard Django templates #1129

brylie opened this issue Oct 12, 2021 · 12 comments

Comments

@brylie
Copy link
Member

brylie commented Oct 12, 2021

Idea summary

Many of our templates are defined with Backbone JavaScript code. However, we want to simplify our project and follow conventional Django development practices. To this end, we want to convert our Backbone code to Django templates.

Further details

This task includes several sub-tasks, outlined below.

Note: this list is work-in-progress, pending some changes to the project folder structure.

@brylie brylie added help wanted community triage Issues that have not been categorized or prioritized code quality enhancement and removed triage Issues that have not been categorized or prioritized labels Oct 12, 2021
@odinmay
Copy link

odinmay commented Oct 14, 2021

Interested in working on this, could you assign it to me? Ill take a look at it

@brylie
Copy link
Member Author

brylie commented Oct 15, 2021

@odinmay, would you help us clarify the scope of work here? E.g., we need to list all of the Backbone templates that need to be ported over to Django template syntax. Could you help by creating that list as a comment on this issue?

@odinmay
Copy link

odinmay commented Oct 15, 2021

@brylie Yeah I can look into it later today. I may need some help as well, this is one of my first contributions but I'm looking forward to trying my best to help

@brylie
Copy link
Member Author

brylie commented Oct 15, 2021

Ok, sounds good. Thanks, @odinmay.

We'll learn about what code changes are needed by looking through the existing code structure. Once we identify a list of Backbone templates, we can divide and prioritize the work.

@AbhijithGanesh
Copy link
Collaborator

Can I be assigned to this along with @odinmay to reduce workload ?

@brylie
Copy link
Member Author

brylie commented Oct 20, 2021

@AbhijithGanesh, would you likevto help make the initial list of Backbone templates? Once we have the initial list of Backbone templates, the work can be divided up.

@AbhijithGanesh
Copy link
Collaborator

I'll develop the list and update it here asap.

@AbhijithGanesh
Copy link
Collaborator

We have about 26 templates, they're as follows:

  • account.html
  • \accounts\templates\accounts\account.html:
  • \accounts\templates\accounts\feed.html:
  • \accounts\templates\accounts\password_reset.html:
  • \accounts\templates\accounts\reset_by_email.html:
  • \accounts\templates\accounts\settings.html:
  • \accounts\templates\accounts\user-setup.html:
  • \accounts\templates\accounts\partials\account\account_base.html:
  • \accounts\templates\accounts\partials\account\account_settings.html:
  • \accounts\templates\accounts\partials\account\login.html:
  • \accounts\templates\accounts\register\entry_base.html:
  • \accounts\templates\accounts\register\login.html:
  • \accounts\templates\accounts\register\register.html:
  • \accounts\templates\accounts\users\password_reset_complete.html:
  • \accounts\templates\accounts\users\password_reset_confirm.html:
  • \accounts\templates\accounts\users\password_reset_done.html:
  • \accounts\templates\accounts\users\password_reset.html:
  • \accounts\templates\accounts\utils\update_settings.html:
  • \core\templates\about.html:
  • \core\templates\base.html:
  • \core\templates\how_it_works.html:
  • \core\templates\landing.html:
  • \core\templates\support_us.html:
  • \threads\templates\threads\general-message.html:
  • \threads\templates\threads\thread.html:
  • \threads\templates\threads\partials\utils\global_nav.html:
    Out of these a couple of them use Django Templating syntax, we need to convert those which doesn't use Django-Syntax

@wassafshahzad
Copy link
Contributor

@brylie can you assign me this issue ?

@brylie
Copy link
Member Author

brylie commented Oct 25, 2021

@wassafshahzad sure. It is a significant issue that consists of two parts (#1151 and #1152). I would appreciate it if you would take the lead and work holistically as you have done previously.

As you probably already understand, we need to

  • convert the Backbone.js code to Django template syntax
  • ensure there are conventional Django (class-based) views serving the relevant endpoints
  • possibly add multiple Django CBVs per app, depending on the complexity of the Backbone templates we are replacing

@brylie brylie assigned wassafshahzad and unassigned odinmay Oct 25, 2021
@brylie brylie added this to the 2.0 milestone Oct 25, 2021
@hauschie
Copy link

Hi I saw that this was unassigned to the users that said they would contribute. Does this mean that the task was completed or is there still work that needs to be done for this? I am a first time contributor.

@kobistar
Copy link

kobistar commented Apr 24, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants