Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuahchou/2396 new RESTFQ for moment #2404

Merged
merged 12 commits into from
Sep 9, 2024

Conversation

loveluthien
Copy link
Collaborator

@loveluthien loveluthien commented Aug 14, 2024

Description

This closed #2396 together with backend PR and its companion protobuf. This PR adds the rest frequency GUI to the moment generator.

Checklist

For linked issues (if there are):

  • assignee and label added
  • GitHub Project estimate added

For the pull request:

  • reviewers and assignee added
  • GitHub Project estimate added
  • changelog updated / no changelog update needed
  • unit test added (for functions with no dependenies)
  • API documentation added (for public variables and methods in stores)

For dependencies:

  • e2e test passing / corresponding fix added / new e2e test created
  • protobuf version bumped / no protobuf version bumped needed
  • protobuf updated to the latest dev commit / no protobuf update needed
  • corresponding ICD test fix added (BackendService changed) / no ICD test fix needed (BackendService unchanged)
  • user manual prepared (for large new features)

@loveluthien loveluthien added requiring backend For issues or pull requests that require work in both frontend and backend awaiting code changes For pull requests that require code changes labels Aug 14, 2024
@loveluthien loveluthien changed the title Kuahchou/2396 new restfrq for moment Kuahchou/2396 new RESTFQ for moment Aug 14, 2024
@loveluthien loveluthien marked this pull request as ready for review August 16, 2024 03:14
@loveluthien loveluthien added awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing and removed awaiting code changes For pull requests that require code changes labels Aug 16, 2024
Copy link
Collaborator

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding changing the unit of rest frequency definition, there are possible use cases:

  1. user manually types in the value: in this case, user needs to configure the right unit first before typing. Or user needs to convert the value in mind if the selected unit is different from the one in user's mind (mostly the value is read from a catalog)
  2. user copies and pasts a value from a catalog: in this case, users need to configure the right unit first before pasting. If pasting happens first and changing the unit later, the value will be changed too.

In both cases. the new feature (synchronize the value and unit) does not help the UX and sometimes hurts. I suggest we keep the original way (desynchronize the value and unit)

@kswang1029 kswang1029 added the awaiting code changes For pull requests that require code changes label Aug 16, 2024
@loveluthien
Copy link
Collaborator Author

Regarding changing the unit of rest frequency definition, there are possible use cases:

  1. user manually types in the value: in this case, user needs to configure the right unit first before typing. Or user needs to convert the value in mind if the selected unit is different from the one in user's mind (mostly the value is read from a catalog)
  2. user copies and pasts a value from a catalog: in this case, users need to configure the right unit first before pasting. If pasting happens first and changing the unit later, the value will be changed too.

In both cases. the new feature (synchronize the value and unit) does not help the UX and sometimes hurts. I suggest we keep the original way (desynchronize the value and unit)

Okay.

@loveluthien loveluthien removed the awaiting code changes For pull requests that require code changes label Aug 16, 2024
Copy link
Collaborator

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is no image loaded, if we enable the spectral profiler widget and then enable its settings dialog, the frontend will crash.

Screenshot 2024-08-19 at 09 12 21

@loveluthien loveluthien added awaiting code changes For pull requests that require code changes and removed awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing labels Aug 21, 2024
@loveluthien
Copy link
Collaborator Author

update:

  • Fix the frontend crash when no image loaded.
  • disable the rest freq. function in the moment generator following SpectralSettingsComponent.

@loveluthien loveluthien requested a review from kswang1029 August 21, 2024 09:50
@loveluthien loveluthien added awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing and removed awaiting code changes For pull requests that require code changes labels Aug 21, 2024
Copy link
Collaborator

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice. 👍 added new e2e tests

Copy link
Collaborator

@YuHsuan-Hwang YuHsuan-Hwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implemented UI looks good. Just some minor comments:

@YuHsuan-Hwang YuHsuan-Hwang removed the awaiting testing For pull requests that require testing label Aug 27, 2024
@YuHsuan-Hwang YuHsuan-Hwang added the awaiting merge For pull requests ready for merge or pending backend/protobuf changes label Sep 2, 2024
@YuHsuan-Hwang
Copy link
Collaborator

Pending for CARTAvis/carta-backend#1387 code review.

@YuHsuan-Hwang YuHsuan-Hwang merged commit 10679c3 into dev Sep 9, 2024
6 checks passed
@YuHsuan-Hwang YuHsuan-Hwang deleted the kuahchou/2396_new_RESTFRQ_for_moment branch September 9, 2024 12:20
@YuHsuan-Hwang YuHsuan-Hwang removed awaiting code review For pull requests that require code review awaiting merge For pull requests ready for merge or pending backend/protobuf changes labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requiring backend For issues or pull requests that require work in both frontend and backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] support setting a new RESTFRQ for moment image generation
3 participants