-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuahchou/2396 new RESTFQ for moment #2404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding changing the unit of rest frequency definition, there are possible use cases:
- user manually types in the value: in this case, user needs to configure the right unit first before typing. Or user needs to convert the value in mind if the selected unit is different from the one in user's mind (mostly the value is read from a catalog)
- user copies and pasts a value from a catalog: in this case, users need to configure the right unit first before pasting. If pasting happens first and changing the unit later, the value will be changed too.
In both cases. the new feature (synchronize the value and unit) does not help the UX and sometimes hurts. I suggest we keep the original way (desynchronize the value and unit)
Okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice. 👍 added new e2e tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implemented UI looks good. Just some minor comments:
src/components/SpectralProfiler/MomentGeneratorComponent/MomentGeneratorComponent.tsx
Outdated
Show resolved
Hide resolved
src/components/SpectralProfiler/MomentGeneratorComponent/MomentGeneratorComponent.tsx
Outdated
Show resolved
Hide resolved
src/components/SpectralProfiler/MomentGeneratorComponent/MomentGeneratorComponent.tsx
Outdated
Show resolved
Hide resolved
Pending for CARTAvis/carta-backend#1387 code review. |
Description
This closed #2396 together with backend PR and its companion protobuf. This PR adds the rest frequency GUI to the moment generator.
Checklist
For linked issues (if there are):
For the pull request:
no changelog update neededunit test added (for functions with no dependenies)For dependencies:
no protobuf version bumped neededno protobuf update neededBackendService
changed) / no ICD test fix needed (BackendService
unchanged)