Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rest frequency in moment generator #1387

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

pford
Copy link
Collaborator

@pford pford commented Jul 23, 2024

Description

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • ICD test passing / corresponding fix added / new ICD test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • protobuf minor version bumped / protobuf version not bumped
  • added reviewers and assignee
  • GitHub Project estimate added

@pford pford added the requiring frontend this backend issue requires work in both frontend and backend label Jul 23, 2024
@kswang1029
Copy link
Contributor

@pford this looks good to be a formal PR.

@pford pford requested review from confluence and kswang1029 August 27, 2024 18:15
@pford pford marked this pull request as ready for review August 27, 2024 18:18
@pford pford added the awaiting code review For pull requests that require code review label Aug 30, 2024
Copy link

github-actions bot commented Sep 9, 2024

Code Coverage

Package Line Rate Health
src.Cache 72%
src.DataStream 44%
src.FileList 67%
src.Frame 36%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 75%
src.Logger 37%
src.Main 52%
src.Region 69%
src.Session 4%
src.Table 52%
src.ThreadingManager 67%
src.Timer 85%
src.Util 38%
Summary 46% (8641 / 18973)

@confluence confluence merged commit eeedd8d into dev Sep 9, 2024
14 checks passed
@confluence confluence deleted the pam/1385_moment_restfreq branch September 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review For pull requests that require code review requiring frontend this backend issue requires work in both frontend and backend requiring protobuf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] support setting a new RESTFRQ for moment image generation
3 participants