-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set rest frequency in moment generator #1387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pford
added
the
requiring frontend
this backend issue requires work in both frontend and backend
label
Jul 23, 2024
12 tasks
@pford this looks good to be a formal PR. |
kswang1029
approved these changes
Aug 28, 2024
confluence
approved these changes
Sep 9, 2024
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting code review
For pull requests that require code review
requiring frontend
this backend issue requires work in both frontend and backend
requiring protobuf
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Closes [enhancement] support setting a new RESTFRQ for moment image generation #1385
How does this PR solve the issue? Give a brief summary.
Set MomentRequest rest frequency in MomentGenerator image coordinate system, then restore image rest freq after moment images created.
Are there any companion PRs (frontend, protobuf)?
Kuahchou/2396 new RESTFQ for moment carta-frontend#2404 + Add rest frequency to moment request carta-protobuf#98
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
Rest frequency will be added to Moment dialog in frontend.
Checklist
no changelog update neededno protobuf update neededprotobuf version not bumped