Thchang/2051 protobufjs version bump #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added package protobufjs-cli for protobuf building * fixed import of package long
TienHao
added
the
awaiting code review
|
@TienHao Please also send a protobuf PR and add the link in the description, thanks. |
loveluthien
approved these changes
Mar 22, 2024
7 tasks
1 task
|
Could you add ICD-RxJS protobuf version bump as another dependent check box? |
kswang1029
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Tested with the corresponding backend PR CARTAvis/carta-backend#1367 and the carta-protobuf PR CARTAvis/carta-protobuf#95. All e2e tests are passing. 👍
crocka
approved these changes
Apr 8, 2024
YuHsuan-Hwang
added
awaiting merge
YuHsuan-Hwang
removed
the
awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR closes #2051
The package
protobufjswas updated to the latest 7.2.6, since there was a bug when we implemented 6.10.8 and it did not be fixed until 7.0.0. And I also added packageprotobufjs-clifor the building tools(pbjs, pbts) have been moved fromprotobufjsafter 7.0.0. Therefore, a update for build_proto.sh in the carta-protobuf was also needed.The companion carta-protobuf PR: CARTAvis/carta-protobuf#95
Checklist
For linked issues (if there are):
For the pull request:
changelog updated/ no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
e2e test passing / corresponding fix added / new e2e test createdno protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendServicechanged)BackendServiceunchanged)user manual prepared (for large new features)