Bump the submodule carta-protobuf #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
kswang1029
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Tested with the frontend PR CARTAvis/carta-frontend#2361 and the carta-protobuf PR CARTAvis/carta-protobuf#95. All e2e tests are passing. 👍
acdo2002
approved these changes
Apr 8, 2024
loveluthien
approved these changes
Apr 8, 2024
confluence
approved these changes
Apr 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is implemented or fixed? Mention the linked issue(s), if any.
Following the update of protobuf package on branches protobuf and carta-frontend, the backend protobuf package is also updated to the version
4.25.3(for C++ protobuf). The new version of protobuf has dependencies onabseilandjsoncpppackages. I have to manually link abseil libraries in order to make the backend build successful. Not sure if this problem only happened on the Mac brew installation for the new version of protobuf package (?)How does this PR solve the issue? Give a brief summary.
No particular issue is related.
Are there any companion PRs (frontend, protobuf)?
Yes, protobuf and carta-frontend.
Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
All tests should not be affected.
Checklist
changelog updated /no changelog update needed/ corresponding fix added / new e2e test created/ corresponding fix added / new ICD test created/ no protobuf update needed/ protobuf version not bumped