Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Selector Initialization Issue When Invoked from Another Module #3

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Fix Selector Initialization Issue When Invoked from Another Module #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a9c34c
Fix Selector Initialization Issue When Invoked from Another Module
zsigmas Jul 30, 2024
039f6e3
applies suspendWhenHidden FALSE to the selector container too
zsigmas Jul 30, 2024
92bdf17
Revert "Fix Selector Initialization Issue When Invoked from Another M…
zsigmas Aug 13, 2024
d122bfd
Revert "applies suspendWhenHidden FALSE to the selector container too"
zsigmas Aug 13, 2024
0036995
applies suspendWhenHidden = FALSE to all renderUIs to containers over…
zsigmas Aug 13, 2024
dc5e8a5
styling
zsigmas Aug 13, 2024
253a99e
remove debug messages
zsigmas Aug 13, 2024
7b6d934
Revert "remove debug messages"
zsigmas Aug 13, 2024
ecd6537
remove debug messages
zsigmas Aug 13, 2024
4c522ce
add comments
zsigmas Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions R/dressing_room.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,13 @@ app_creator_feedback_server <- function(id, warning_messages, error_messages, ui
if (length(error_messages()) == 0) res <- append(res, list(ui))
return(res)
})

# See: (ag4hj)
shiny::outputOptions(output, "ui", suspendWhenHidden = FALSE)
}
)



return(module)
}
9 changes: 9 additions & 0 deletions R/mod_patient_profile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ mod_patient_profile_server <- function(id, subject_level_dataset, extra_datasets
return(res)
})

# (ag4hj): Without these outputOptions the update selector (See: ag4hj) tries to update a selector that is not yet
# in the UI. Therefore the update is lost. In practice this means that when using the receiver_ids the first
# subjid is lost and the interaction is incorrect.
shiny::outputOptions(output, "ui", suspendWhenHidden = FALSE)

output[["selector"]] <- shiny::renderUI({
subject_level_dataset <- subject_level_dataset()
shiny::req(subject_level_dataset, cancelOutput = TRUE)
Expand All @@ -98,6 +103,10 @@ mod_patient_profile_server <- function(id, subject_level_dataset, extra_datasets
)
})

# See: (ag4hj)
shiny::outputOptions(output, "selector", suspendWhenHidden = FALSE)

# See: (ag4hj)
# change selected patient based on sender_ids
if (!is.null(sender_ids)) {
lapply(sender_ids, function(x) {
Expand Down