Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Selector Initialization Issue When Invoked from Another Module #3

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Fix Selector Initialization Issue When Invoked from Another Module #3

merged 10 commits into from
Aug 13, 2024

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Jul 30, 2024

When the selector is invoked from another module, it isn't ready yet, resulting in the selected subjid not being passed correctly.

@zsigmas
Fix Selector Initialization Issue When Invoked from Another Module
8a9c34c 
When the selector is invoked from another module, it isn't ready yet, resulting in the selected subjid not being passed correctly.
@zsigmas zsigmas closed this Jul 30, 2024
@zsigmas zsigmas reopened this Jul 30, 2024
@zsigmas zsigmas requested a review from mattkorb August 13, 2024 10:36
@zsigmas zsigmas self-assigned this Aug 13, 2024
@zsigmas zsigmas marked this pull request as ready for review August 13, 2024 10:36
@zsigmas zsigmas requested a review from a team as a code owner August 13, 2024 10:36
@zsigmas zsigmas changed the base branch from main to dev August 13, 2024 10:38
@zsigmas
Copy link
Contributor Author

zsigmas commented Aug 13, 2024

closes #4

mattkorb
mattkorb approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@mattkorb mattkorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zsigmas Looks good to me.
The only thing we could add is a comment to the lines of code to you added, to mention why this is needed so that we remember this in the future.

@zsigmas zsigmas merged commit 4f3e63e into dev Aug 13, 2024
7 checks passed
@zsigmas zsigmas deleted the fix/selector-initialization-issue branch August 13, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkorb mattkorb mattkorb approved these changes

Assignees

@zsigmas zsigmas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsigmas @mattkorb