Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using @import in scss #284

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

Samuel-Therrien-Beslogic
Copy link
Contributor

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic commented Nov 9, 2024

  • The project passes automated tests (build, linting, etc.).
  • You updated the project's documentation with new changes.
  • You've linked any issue this PR closes
  • You reviewed your own PR and made sure there's no test/debug code or any obvious mistakes.

Make sure that the code wasn't copied from elsewhere (check one):

  • This is your own original code
  • You have made sure that we have permission to use the copied code and that we follow its licensing

Closes #281

This is a very important fix performance-wise:

  • Downloads a lot less
  • Debugging CSS is a lot easier now that styles aren't set 7 times each
  • Vite's "Fast refresh" stops being unresponsive for a while
  • Probably fixes my Edge dev tool crashes (at least haven't had one in a while and it feels more responsive)

Copy link
Contributor

@andy2great andy2great left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic merged commit 5bb779d into main Nov 12, 2024
3 checks passed
@Samuel-Therrien-Beslogic Samuel-Therrien-Beslogic deleted the Stop-using-@import-in-scss branch November 12, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @use instead of @import in scss (or reduce import duplication)
2 participants