Proper use of theme colors + Improved navbar #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- leaked achor CSS with !Important - Reduced a layer of div inside anchor - Fixed squised images - Fixed completely broken Card display in mobile view
Samuel-Therrien-Beslogic
requested review from
theo-auffeuvre,
BesOlivierBouchard and
NicolasDontigny
as code owners
…to bugfix/proper-use-of-theme-colors
| @@ -15,7 +14,7 @@ | |||
| } | |||
|
|
|||
| @media screen and (min-width: $large-width) { | |||
| .header-card { | |||
| .header-card.header-card { | |||
There was a problem hiding this comment.
TODO: Validate if doubling is still needed now that we don't re-import global style
Samuel-Therrien-Beslogic
added a commit
that referenced
this pull request
Nov 15, 2024
|
I could also split-off translation keys changes, not sure if worth. |
Samuel-Therrien-Beslogic
changed the title
Samuel-Therrien-Beslogic
deleted the
bugfix/proper-use-of-theme-colors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the code wasn't copied from elsewhere (check one):
Includes #282 , #283 and #284 , please review and merge those first
This PR properly configures bootstrap to leverage the design system we use as much as possible (except for the few TODOs left in code) as well as tweaking the configurations for rsuite and MUI as necessary to match. The goal being to follow the Figma design document with minimal specialized code in components.
The navbars have been revamped to match the Figma design document as closely as possible.