Nitpicks to reduce changes from #279

BesLogic · Nov 15, 2024 · 153692d · 153692d
1 parent 5711a78
commit 153692d
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 10 deletions.
diff --git a/canopeum_frontend/src/components/analytics/SiteSuccessRatesChart.tsx b/canopeum_frontend/src/components/analytics/SiteSuccessRatesChart.tsx
@@ -58,6 +58,7 @@ const SiteSuccessRatesChart = ({ siteSummaries }: Props) => {
 
   const renderChartTooltip = (props: ChartsAxisContentProps) => {
     const selectedSerie = props.series.find(serie => serie.id === props.axisValue)
+    // @typescript-eslint/no-unsafe-type-assertion -- value type is known from the context
     const data = selectedSerie?.data.find(value => !!value) as number | undefined
 
     return (

diff --git a/canopeum_frontend/src/components/inputs/MultipleSelectChip.tsx b/canopeum_frontend/src/components/inputs/MultipleSelectChip.tsx
@@ -66,7 +66,7 @@ const MultipleSelectChip = <TValue extends SelectionValueType>(
             <Box sx={{ display: 'flex', flexWrap: 'wrap', gap: 0.5 }}>
               {
                 // TODO(NicolasDontigny): Find a more efficient way
-                // map values to their display text here
+                // to map values to their display text here
               }
               {selected
                 .map(value => options.find(option => option.value === value))

diff --git a/canopeum_frontend/src/components/settings/AdminInvitationDialog.tsx b/canopeum_frontend/src/components/settings/AdminInvitationDialog.tsx
@@ -124,7 +124,7 @@ const AdminInvitationDialog = ({ open, handleClose }: Props) => {
               emailError
                 ? 'is-invalid'
                 : ''
-            } `}
+            }`}
             id='email-input'
             onBlur={() => validateEmail()}
             onChange={event => setEmail(event.target.value)}

diff --git a/canopeum_frontend/src/components/settings/EditProfile.tsx b/canopeum_frontend/src/components/settings/EditProfile.tsx
@@ -291,7 +291,7 @@ const EditProfile = () => {
                         Could be fixed by creating a global Input component */
                         ? 'is-invalid'
                         : ''
-                    } `}
+                    }`}
                     id='password-input'
                     onBlur={() => validateCurrentPassword()}
                     onChange={event => setCurrentPassword(event.target.value)}
@@ -314,7 +314,7 @@ const EditProfile = () => {
                       newPasswordError
                         ? 'is-invalid'
                         : ''
-                    } `}
+                    }`}
                     id='password-input'
                     onBlur={() => validateNewPassword()}
                     onChange={event => setNewPassword(event.target.value)}

diff --git a/canopeum_frontend/src/models/Coordinate.ts b/canopeum_frontend/src/models/Coordinate.ts
@@ -35,7 +35,8 @@ export const extractCoordinate = (coordinates: string) => {
   const char3 = coordinates.indexOf('.')
   const char4 = coordinates.indexOf('"')
 
-  /* NOTE: It should be impossible for the nullish coalescence to happen here,
+  /* @typescript-eslint/no-unsafe-type-assertion --
+  NOTE: It should be impossible for the nullish coalescence to happen here,
   We're also type-guarding the string union immediatly after */
   const cardinal = coordinates.at(-1) as Cardinal
   if (!(VALID_CARDINALS.includes(cardinal))) {

diff --git a/canopeum_frontend/src/pages/Login.tsx b/canopeum_frontend/src/pages/Login.tsx
@@ -93,7 +93,7 @@ const Login = () => {
               emailError
                 ? 'is-invalid'
                 : ''
-            } `}
+            }`}
             id='email-input'
             onBlur={() => validateEmail()}
             onChange={event => setEmail(event.target.value)}
@@ -113,7 +113,7 @@ const Login = () => {
               passwordError
                 ? 'is-invalid'
                 : ''
-            } `}
+            }`}
             id='password-input'
             onBlur={() => validatePassword()}
             onChange={event => setPassword(event.target.value)}

diff --git a/canopeum_frontend/src/pages/Register.tsx b/canopeum_frontend/src/pages/Register.tsx
@@ -187,7 +187,7 @@ const Register = () => {
                   -- Create an Input Component? */
                   ? 'is-invalid'
                   : ''
-              } `}
+              }`}
               id='username-input'
               onBlur={() => validateUsername()}
               onChange={event => setUsername(event.target.value)}
@@ -208,7 +208,7 @@ const Register = () => {
                 emailError
                   ? 'is-invalid'
                   : ''
-              } `}
+              }`}
               disabled={!!userInvitation}
               id='email-input'
               onBlur={() => validateEmail()}
@@ -235,7 +235,7 @@ const Register = () => {
                 passwordError
                   ? 'is-invalid'
                   : ''
-              } `}
+              }`}
               id='password-input'
               onBlur={() => validatePassword()}
               onChange={event => setPassword(event.target.value)}