Improve map cards responsiveness #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- leaked achor CSS with !Important - Reduced a layer of div inside anchor - Fixed squised images - Fixed completely broken Card display in mobile view
Samuel-Therrien-Beslogic
requested review from
theo-auffeuvre,
BesOlivierBouchard and
NicolasDontigny
as code owners
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the code wasn't copied from elsewhere (check one):
Before: See #275
This isn't a full fix for perfect responsiveness on mobile (so I'll keep the issue open). But this addresses the critical issues. There's still one specific zoom + window width combination where this happens (notice the images not completely covering and the double scrollbar)
Fixes: