-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages: Sorting and Pagination #96
Conversation
Hey @ChristianTovar it's looking good. Just found a small bug. When there are no pages, it displays the following: Clicking on the %Postgrex.Error{message: nil, postgres: %{code: :invalid_row_count_in_result_offset_clause, line: "374", message: "OFFSET must not be negative", ...}
|
@leandrocp I've fixed the error for when there are no pages at all, we won't render the pagination component nor the upper sorting element. We still have some tests that are complaining about some code that is currently on beacon core for counting pages, how do we use the latest up-to-date beacon core stuff in tests for this particular case? |
👍🏻
You can just update the dependency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Feel free to merge it thanks!
Description
Issue
This PR tackles #87
Screenshots
Pagination Component Demo
Screen.Recording.2023-12-07.at.1.20.25.PM.mov