Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pages: Sorting and Pagination #87

Closed
leandrocp opened this issue Nov 1, 2023 · 1 comment · Fixed by #96 or BeaconCMS/beacon#381
Closed

Pages: Sorting and Pagination #87

leandrocp opened this issue Nov 1, 2023 · 1 comment · Fixed by #96 or BeaconCMS/beacon#381
Assignees
@ChristianTovar
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Milestone
v0.1.0

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Nov 1, 2023 •
edited
Loading

Rules

  • Sort by title, path, status
  • Paginate by page, 20 records by page
  • Use query params to preserve state as ?query=FOO&page=INT&sort=NAME
  • Searching should reset pagination to page 1 and preserve sort query param and current state
  • Paginating should preserve search query and sort params and their current state
  • Display a navigation bar like this one below:

Image

Related code

beacon_live_admin/lib/beacon/live_admin/content.ex

Line 96 in f774eaa

def list_pages(site, opts \\ []) do

https://github.com/BeaconCMS/beacon/blob/cbe3bf7445cc559c96310593105e710366ed2cea/lib/beacon/content.ex#L757
@leandrocp leandrocp added enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors labels Nov 1, 2023
@leandrocp leandrocp added this to Beacon Nov 1, 2023
@leandrocp leandrocp moved this to Todo in Beacon Nov 1, 2023
@AZholtkevych AZholtkevych added this to the v0.1.0 milestone Nov 16, 2023
@leandrocp leandrocp moved this from Todo to In Progress in Beacon Nov 17, 2023
@AZholtkevych AZholtkevych mentioned this issue Nov 22, 2023
Closed
29 tasks
@ChristianTovar ChristianTovar mentioned this issue Dec 7, 2023
Merged
6 tasks
@AZholtkevych AZholtkevych linked a pull request Dec 15, 2023 that will close this issue
Pages: Sorting and Pagination #96
Merged
6 tasks
@AZholtkevych AZholtkevych linked a pull request Jan 12, 2024 that will close this issue
Add offset support for listing pages and counting pages BeaconCMS/beacon#381
Merged
@AZholtkevych AZholtkevych moved this from In Progress to Code Review in Beacon Jan 16, 2024
@AZholtkevych AZholtkevych moved this from Code Review to Backlog in Beacon Jan 16, 2024
@AZholtkevych AZholtkevych moved this from Backlog to Code Review in Beacon Jan 16, 2024
@AZholtkevych AZholtkevych moved this from Code Review to Done in Beacon Jan 26, 2024
@AZholtkevych
Copy link

@ChristianTovar thank you so much, amazing job

@AZholtkevych AZholtkevych mentioned this issue Apr 21, 2024
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianTovar ChristianTovar

Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Projects
Beacon
Status: Done
Milestone
v0.1.0
3 participants
@leandrocp @ChristianTovar @AZholtkevych