Merge pull request #69 from Banno/async-go

fix: make router.go async
Banno · Nov 1, 2023 · 605e09e · 605e09e
2 parents 1ee4787 + ed777a8
commit 605e09e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jack-henry/web-component-router",
-  "version": "3.0.2",
+  "version": "3.1.0",
   "description": "Web Components Router",
   "main": "router.js",
   "type": "module",

diff --git a/router.js b/router.js
@@ -115,10 +115,11 @@ class Router {
    * Navigate to the specified route
    * @param {string} path
    * @param {Object=} params Values to use for named & query parameters
+   * @returns {!Promise<!Context>}
    */
-  go(path, params) {
+  async go(path, params) {
     path = this.url(path, params);
-    this.page.show(path);
+    return this.page.show(path);
   }
 
   /**

diff --git a/test/router-spec.js b/test/router-spec.js
@@ -206,7 +206,8 @@ describe('Router', () => {
 
   describe('go()', () => {
     beforeEach(() => {
-      spyOn(router.page, JSCompiler_renameProperty('show', router.page));
+      spyOn(router.page, JSCompiler_renameProperty('show', router.page)).
+        and.callFake(async (path) => new Context(path));
     });
 
     it('should navigate to the given path', () => {
@@ -221,8 +222,14 @@ describe('Router', () => {
       });
       expect(router.page.show).toHaveBeenCalledWith('/account/1234/documents/6789');
     });
+    it('should resolve to a Context', async () => {
+      const rp = await router.go('/A');
+      expect(rp instanceof Context);
+    });
   });
 
+
+
   describe('query context', () => {
     afterEach(() => {
       // Remove the callback added in the test.