Merge pull request #68 from Banno/readme-fix

updating test
Banno · Oct 26, 2023 · 1ee4787 · 1ee4787
2 parents e1426e9 + 93f773c
commit 1ee4787
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@jack-henry/web-component-router",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Web Components Router",
   "main": "router.js",
   "type": "module",

diff --git a/router.js b/router.js
@@ -20,7 +20,7 @@
  * @property {string} id
  * @property {string} tagName
  * @property {string} path
- * @property {Array<string>=} parameters
+ * @property {Array<string>=} params
  * @property {boolean=} authenticated
  * @property {Array<RouteConfig>=} subRoutes
  */
@@ -82,7 +82,7 @@ class Router {
   /** @param {!RouteConfig} routeConfig */
   buildRouteTree(routeConfig) {
     const authenticated = [true, false].includes(routeConfig.authenticated) ?  routeConfig.authenticated : true;
-    const node = new RouteTreeNode(new RouteData(routeConfig.id, routeConfig.tagName, routeConfig.path, routeConfig.parameters || [], authenticated));
+    const node = new RouteTreeNode(new RouteData(routeConfig.id, routeConfig.tagName, routeConfig.path, routeConfig.params || [], authenticated));
     if (routeConfig.subRoutes) {
       routeConfig.subRoutes.forEach(route => {
         node.addChild(this.buildRouteTree(route));

diff --git a/test/router-spec.js b/test/router-spec.js
@@ -110,11 +110,13 @@ describe('Router', () => {
         tagName: 'APP-USER-PAGE',
         path: '/users/:userId([0-9]{1,6})',
         requiresAuthentication: true,
+        params: ['userId'],
     }, {
         id: 'app-user-account',
         tagName: 'APP-ACCOUNT-PAGE',
         path: '/users/:userId([0-9]{1,6})/accounts/:accountId([0-9]{1,6})',
         requiresAuthentication: true,
+        params: ['userId', 'accountId'],
     }, {
       id: 'app-about',
       tagName: 'APP-ABOUT',
@@ -130,9 +132,13 @@ describe('Router', () => {
       expect(subRoutes.length).toBe(3);
       subRoutes.forEach((route, index) => {
         const data = route.getValue();
+        if (testSubRouteData[index].params) {
+          expect(Object.keys(data.attributes)).toEqual(testSubRouteData[index].params);
+        }
         ['id', 'tagName', 'path', 'requiresAuthentication'].forEach((prop) => {
           expect(data[prop]).toBe(testSubRouteData[index][prop]);
-        })
+        });
+
       });
     });