Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix Variable Width Scrolling with CSS Gutters #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sjstark
Copy link
Member

@sjstark sjstark commented May 13, 2024

Aims to address #147 where variable width carousels with CSS set Gutters will error out.

Current state of PR fixes error, but allows non-paginated carousels to scroll past end point.

Copy link

codesandbox bot commented May 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented May 13, 2024

Deploy Preview for vue-ssr-carousel ready!

Name Link
🔨 Latest commit 9c463d2
🔍 Latest deploy log https://app.netlify.com/sites/vue-ssr-carousel/deploys/66426457e3a55700072c8aaf
😎 Deploy Preview https://deploy-preview-148--vue-ssr-carousel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 13, 2024

2 failed tests on run #125 ↗︎

2 16 0 0 Flakiness 0

Details:

start fixing variable width scroll for css gutters
Project: vue-ssr-carousel Commit: 9c463d2796
Status: Failed Duration: 01:35 💡
Started: May 13, 2024 7:04 PM Ended: May 13, 2024 7:06 PM
Failed  cypress/e2e/responsive.coffee • 2 failed tests

View Output Video

Test Artifacts
responsive > variable width > can't be dragged past last slide Screenshots Video
responsive > variable width > can be disabled Screenshots Video

Review all test suite changes for PR #148 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant