Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting slidesPerPage to null throws error when dragging #147

Open
ajrowland opened this issue May 3, 2024 · 4 comments
Open

Setting slidesPerPage to null throws error when dragging #147

ajrowland opened this issue May 3, 2024 · 4 comments

Comments

@ajrowland
Copy link
Contributor

Since upgrading from 2.5.0 from 2.4.2, and using the following carousel settings:

    {
        showDots: false,
        showArrows: false,
        slidesPerPage: null,
        gutter: "0.5rem",
      }

Dragging the carousel throws the following error:

Cannot read properties of undefined (reading 'targetXScroll')
    at VueComponent.fractionalIndexFromMeasurements (index.js:1312:1)

Could this be an issue with the package, or does our implementation have to change?

Great work by the way. Thanks for your efforts.

@weotch
Copy link
Member

weotch commented May 3, 2024

@sjstark think you can take a look at this?

@sjstark
Copy link
Member

sjstark commented May 13, 2024

looking into this now

@sjstark
Copy link
Member

sjstark commented May 13, 2024

Issue comes into play with CSS set gutters (which packages should allow for based on prior implementations) Need to think of a solve for this, but recommend downgrading to 2.4.2 in the meantime. Current solve I'm looking at in #148 still does not allow for CSS property gutters for paginated variable width carousels, only number based gutters. Apologies for missing this, every implementation we've had for the carousel used hard number gutters and I didn't even realized the carousel allowed for css property gutters.

@ajrowland
Copy link
Contributor Author

@sjstark Thanks for the update. Have downgraded in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants