Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AML - Idle Shutdown test #2475

Closed
wants to merge 29 commits into from
Closed

AML - Idle Shutdown test #2475

wants to merge 29 commits into from

Conversation

batemansogq
Copy link
Contributor

PR Summary

Additional AML test covering idle shutdown control on compute instances.
The first update from the secure AML design work.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@batemansogq batemansogq requested a review from a team as a code owner October 9, 2023 11:14
BernieWhite
BernieWhite requested changes Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @batemansogq. I made a few minor tweaks and have a few suggestions below for you to review. Any questions let me know.

docs/en/rules/Azure.ML.ComputeIdleShutdown.md Show resolved Hide resolved
docs/en/rules/Azure.ML.ComputeIdleShutdown.md Show resolved Hide resolved
docs/en/rules/Azure.ML.ComputeIdleShutdown.md Outdated Show resolved Hide resolved
docs/en/rules/Azure.ML.ComputeIdleShutdown.md Show resolved Hide resolved
src/PSRule.Rules.Azure/rules/Azure.ML.Rule.yaml Show resolved Hide resolved
docs/en/rules/Azure.ML.ComputeVnet.md Show resolved Hide resolved
src/PSRule.Rules.Azure/rules/Azure.ML.Rule.yaml Show resolved Hide resolved
docs/en/rules/Azure.ML.WrkspPublicAccess.md Show resolved Hide resolved
docs/en/rules/Azure.ML.WrkspPublicAccess.md Show resolved Hide resolved
docs/en/rules/Azure.ML.WrkspPublicAccess.md Show resolved Hide resolved
@BernieWhite BernieWhite linked an issue Oct 15, 2023 that may be closed by this pull request
Initial rules for Azure Machine Learning #2484
Closed
@nfmoore
Copy link

nfmoore commented Oct 19, 2023

The rules look good @batemansogq. Don't see any issues.

@BernieWhite BernieWhite mentioned this pull request Oct 19, 2023
Closed
11 tasks
@BernieWhite
Copy link
Collaborator

Replaced by #2500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial rules for Azure Machine Learning
3 participants
@batemansogq @nfmoore @BernieWhite