Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML - disable local admin, behind vnet & idle shutdown #2476

Closed
wants to merge 23 commits into from

Conversation

batemansogq
Copy link
Contributor

PR Summary

The initial set of AML rules

  • disable local admin for compute
  • compute hosted within a vnet
  • compute idle shutdown

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@batemansogq batemansogq requested a review from a team as a code owner October 10, 2023 11:12
@batemansogq
Copy link
Contributor Author

accepted all of the suggestions - update minor text, corrected the ML User rule mkdwn

@BernieWhite
Copy link
Collaborator

accepted all of the suggestions - update minor text, corrected the ML User rule mkdwn

:) Sorry i'm confused there is another PR #2475 that has some but not all of the rules.

I was planning to review this PR after that one was merged so that I didn't need to double up on reviewing the same files or should we just close the other PR and start a review here?

@batemansogq
Copy link
Contributor Author

OK, lets close this and go again.

@batemansogq
Copy link
Contributor Author

closing as advised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants