Egui image api #72
Merged
Egui image api #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e monolithic bind group
* feat: add Source Han Sans (for displaying CJK characters) * perf: compress fonts to reduce binary size
melody-rs
force-pushed
the
egui-image-api
branch
from
8dcbafa to
d84b44b
Compare
white-axe
requested changes
Dec 3, 2023
There was a problem hiding this comment.
I get this wgpu error when enabling the collision shader on native (web is fine):
wgpu error: Validation Error
Caused by:
In a RenderPass
note: encoder = `encoder`
In a draw command, indexed:false indirect:false
note: render pipeline = `Tilemap Collision Render Pipeline`
The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 0 which is incompatible with the bind group layout associated with the bind group at 0
I don't know how I missed this, but the collision shader still expected there to be a bind group when we weren't passing one!
|
Should be fixed now! |
white-axe
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
egui
0.23.0got a new image API, and deprecatedegui_extras::RetainedImage. This pull request adds a custom egui image loader to load from the project filesystem.This allows us to use
ui.image("project://{})"to display images from the currently open project in a way that aligns with egui's design.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo build --releasetrunk build --release