Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.xml: add CAPA indicating mission-slot-0 is home #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link

ArduPilot stores home position in the first element of the mission.

Other autopilots do not.

Add a capability bit indicating that ArduPilot is doing this, which ArduPilot will set. Eventually this will allow ArduPilot to not store home in slot-0 - or at least not as far as the item transfer protocols are concerned (including FTP).

No new autopilot should set the bit.

The concept is:

  • ArduPilot starts to send this bit
  • GCSs start to understand this bit, and will do the "slot-0-is-home" if the bit is set, as well as the existing special case for ArduPilot.
  • After ArduPilot has been sending this bit for a prolonged period of time GCSs can remove the special-case for ArduPilot, relying on the bit.
  • After the GCSs can have been expected to support the bit for some prolonged period of time ArduPilot can stop setting the bit.
  • After even more time ArduPilot can stop setting the bit and start transferring the missions without home in them
  • eventually everyone is transferring missions without home in them and we can deprecate the bit entirely as unused

Drawback: the mavlink node initiating transfer MUST know the MAV_PROTOCOL_CAPABILITY mask of the autopilot before it can start a mission transfer

@peterbarker
Copy link
Author

UTC1103 - https://github.com/ArduPilot/mavlink/pull/360
Could do a special NAV_HOME mission item type too
Parsing tlogs - don’t have capability bits so you don’t know what home is
GCSs which can’t read capabilities can’t work (e.g. read-only GCSs)
Still don’t know whether to add home at slot 0
Probably need the capability flags
Introduce NAV_HOME at the same time
Can NAV_HOME be anywhere than slot-0?
Nav_home an be displayed specially on the map
Will come back to it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants