Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint eslint-config-sheriff with eslint-config-sheriff #162

Closed
wants to merge 1 commit into from

Conversation

lishaduck
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:44am

Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: 35747fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AndreaPontrandolfo
Copy link
Owner

I think we need to wait for #161 before tackling this PR.

@lishaduck
Copy link
Contributor Author

I think we need to wait for #161 before tackling this PR.

There's not a direct dependency, but as I don't have it cloned, I'm fine to wait.

@lishaduck lishaduck mentioned this pull request Aug 25, 2024
@lishaduck
Copy link
Contributor Author

This's collected a bunch of conflicts, so I'm closing in favor of #236.
I'll probably rewrite it someday, but I'm busy on some work over in elm-review (and school started back up), so it's not high on my todo list.
I want to express my gratitude for sheriff real quick though, it's been great to be able to come help out (and it's an amazingly done preset as well).

@lishaduck lishaduck closed this Aug 25, 2024
@AndreaPontrandolfo
Copy link
Owner

@lishaduck i wish you good luck on elm-review and school! I'm sure you will rock it!!
Come back here whenever you feel like it!

I want to express my gratitude for sheriff real quick though, it's been great to be able to come help out (and it's an amazingly done preset as well).

Likewise, i thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants