Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndreaPontrandolfo/issue236 #326

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

AndreaPontrandolfo
Copy link
Owner

@AndreaPontrandolfo AndreaPontrandolfo commented Dec 21, 2024

Closes #236

Copy link

changeset-bot bot commented Dec 21, 2024

🦋 Changeset detected

Latest commit: ee74f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
eslint-config-sheriff Patch
@sherifforg/create-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 4:01pm

@AndreaPontrandolfo
Copy link
Owner Author

@lishaduck with this PR, i tried to integrate most of the most significant changes that you did in #161 and #162.
Let me know what you think! 😊

@AndreaPontrandolfo AndreaPontrandolfo merged commit 74119dd into master Dec 21, 2024
3 checks passed
@AndreaPontrandolfo AndreaPontrandolfo deleted the AndreaPontrandolfo/issue236 branch December 21, 2024 16:04
Copy link
Contributor

@lishaduck lishaduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why there were some ignores added.

@AndreaPontrandolfo AndreaPontrandolfo mentioned this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dogfood
2 participants