-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating cross_seg_comparison into seg_compare script #3
Conversation
egelfan2
commented
Oct 11, 2024
- remove cross_seg_comparison standalone script
- integrated cross_seg_comparison functionality with seg_compare script
- updated seg_compare user guide to show functionality (sankey diagram doesn't load in github browser but functions)
code has been integrated with spatial compare script
@egelfan2 can you fix the merge conflicts? maybe you made your initial branch a while back? |
Updated to remove merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the requirement(s), make sure things work with a fresh pip install. I also added issue #5, which would have caught this. we can merge this once the requirements are in and then add testing in another PR.
@@ -6,15 +6,16 @@ | |||
import scanpy as sc | |||
import seaborn as sns | |||
from scipy import sparse | |||
from scipy.spatial import cKDTree | |||
from pathlib import Path | |||
import plotly.graph_objs as go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add plotly as a requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added plotly (and requisite dependency kaleido for saving png images) and tested fresh install
I'll try the png loading option, unfortunately the direct loading doesn't seem to work with jupyter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good