-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create splash page for web #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswallace
requested review from
SeanLeRoy,
kmitcham,
pgarrison and
BrianWhitneyAI
May 20, 2024 19:30
SeanLeRoy
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work Anya!
--dark-grey: #313131; | ||
--medium-grey: #4B4B4B; | ||
--light-grey: #BFBFBF; | ||
--white: #ffffff; | ||
--red: #c23030; | ||
|
||
/* DEFAULT THEME (dark theme) */ | ||
/* To do: Update greys to new theme, check components for consistency */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this being kept maintained!
kmitcham
approved these changes
May 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the splash page based on the Figma prototype. Currently has placeholders for the carousel images/text and the walkthrough video, as well as empty routes to the datasets and learn pages.
Also adds the global header (web only) with conditional menu items
Closes #88
Changes
Screenshots
Figma design
Implementation